[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] file-name.c and MinGW paths.

From: John McCabe-Dansted
Subject: Re: [PATCH] file-name.c and MinGW paths.
Date: Sun, 18 Feb 2007 10:35:50 +0900

On 2/18/07, Ben Pfaff <address@hidden> wrote:
> however the GetFullPathName function would help:
> should be good enough for our purposes.

Seeing as GetFullPathName seems to do what we want, and
canonicalize_filename_mode doesn't, and we don't use
canonicalize_filename_mode anywhere else in PSPP, I suppose we
should just drop canonicalize_filename_mode entirely (and the
"canonicalize" gnulib module) and just use GetFullPathName
directly in fn_get_identity.

Do we still need canonicalize under unix? Should the gnulib
canonicalize function itself be a wrapper around GetFullPathName in

> We also probably also convert the pathname to upper-case in
> canonicalize as well, although that seems somehow ugly to me.

Or use strcasecmp in fn_compare_file_identities.

Sounds nicer. OTOH, if we push this up into gnulib, then gnulib based
software would have to be careful to use FN_STRCMP (where this macro
is defined appropriately on mingw and posix platforms) to compare
canonicalized filenames.

John C. McCabe-Dansted
PhD Student
University of Western Australia

reply via email to

[Prev in Thread] Current Thread [Next in Thread]