[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] file-name.c and MinGW paths.

From: John McCabe-Dansted
Subject: Re: [PATCH] file-name.c and MinGW paths.
Date: Sun, 18 Feb 2007 15:39:28 +0900

In dirname.h:

# ifndef ISSLASH
# endif

This does not support systems with more than one directory_seperator.
We probably want the ISSLASH from "pathname.h". To use pathname.h, we
have to #include it *before* we #include "dirname.h" (and request it
from gnulib in Smake).

+  char cname[PATH_MAX];

I have heard that it is a good habit to avoid arrays on the stack, as
they can be security holes, and can overflow the stack if the array
size is large compared to the stack size on an architecture.

This is a nit, and obviously the overall programming style in PSPP is
your call. Indeed, I imagine a decision counter to this has already
made, but I thought I'd explain my programming style, just in case it
so happened the issue had never been considered.

I must admit that the style of your patch here seems somehow cleaner to me.

John C. McCabe-Dansted
PhD Student
University of Western Australia

reply via email to

[Prev in Thread] Current Thread [Next in Thread]