[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [patch 0/7] some bits of simpler-proc ready for review

From: Ben Pfaff
Subject: Re: [patch 0/7] some bits of simpler-proc ready for review
Date: Sun, 03 Jun 2007 08:31:23 -0700
User-agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux)

John Darrington <address@hidden> writes:

> I would suggest that we try merging in bigger chunks.  If each patch
> is going to be as small as these, then it'll take a long time.  Maybe 
> try it on a per directory basis.  For example Smake, and 
> I think could be merged immediately.  Probably everything
> in libpspp too.  If a patch proves to be controversial, then it can be 
> split into smaller ones.

This is just the odds and ends.  Most of the rest will be bigger

> In so far as these patches go, the only concern I have is removing the 
> next/prev/up pointers from the documentation.  It will make the manual 
> harder to navigate.

Removing the pointers from the documentation has no effect on the
.info file, because the makeinfo program is smart enough to
reconstruct the pointers.  It just makes it easier to maintain
the Texinfo files, because now you can move around nodes without
having to update any next/prev/up pointers (either by hand or
with Emacs assistance).

> Last week I had a look at the other things that need to be merged. One
> mental note I made was that math/ordering.[ch] ought to be moved to
> data --- it results in circular dependencies being in math, and it 
> pertains to data definition/semantics so probably makes more sense in 
> src/data

Yes I agree.
"...I've forgotten where I was going with this,
 but you can bet it was scathing."

reply via email to

[Prev in Thread] Current Thread [Next in Thread]