Re: [patch 01/19] move casenumber to case.h

[John Darrington]

No problem here.

On Tue, Jun 05, 2007 at 11:27:28PM -0700, address@hidden wrote:
     The casenumber type is defined in transformations.h, but case.h is a
     more sensible place.  Move it.  Also define a new constant
     CASENUMBER_MAX.
     
     Index: merge/src/data/case.h
     ===================================================================
     --- merge.orig/src/data/case.h     2007-06-02 16:54:53.000000000 -0700
     +++ merge/src/data/case.h  2007-06-02 16:56:03.000000000 -0700
     @@ -26,6 +26,11 @@
      
      struct variable;
      
     +/* A count of cases or the index of a case within a collection of
     +   them. */
     +#define CASENUMBER_MAX LONG_MAX
     +typedef long int casenumber;
     +
      /* Opaque structure that represents a case.  Use accessor
         functions instead of accessing any members directly.  Use
         case_move() or case_clone() instead of copying.  */
     @@ -44,7 +50,7 @@
      
      size_t case_get_value_cnt (const struct ccase *);
      
     -void case_resize (struct ccase *, size_t new_value_cnt);
     +void case_resize (struct ccase *, size_t new_cnt);
      void case_swap (struct ccase *, struct ccase *);
      
      bool case_try_create (struct ccase *, size_t value_cnt);
     Index: merge/src/data/transformations.h
     ===================================================================
     --- merge.orig/src/data/transformations.h  2007-06-02 16:54:54.000000000 
-0700
     +++ merge/src/data/transformations.h       2007-06-02 16:56:03.000000000 
-0700
     @@ -19,10 +19,10 @@
      #ifndef TRANSFORMATIONS_H
      #define TRANSFORMATIONS_H 1
      
     +#include <limits.h>
      #include <stdbool.h>
      #include <stddef.h>
     -
     -typedef unsigned long casenumber ;
     +#include <data/case.h>
      
      /* trns_proc_func return values. */
      enum trns_result 
     
     --
     
     
     
     _______________________________________________
     pspp-dev mailing list
     address@hidden
     http://lists.gnu.org/mailman/listinfo/pspp-dev

-- 
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://pgp.mit.edu or any PGP keyserver for public key.

signature.asc
Description: Digital signature