pspp-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [patch 10/19] new function value_cnt_from_width


From: Ben Pfaff
Subject: Re: [patch 10/19] new function value_cnt_from_width
Date: Wed, 06 Jun 2007 22:46:02 -0700
User-agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux)

Someday that may be a good idea but for now the definition of
struct variable is only in variable.c not in variable.h.

John Darrington <address@hidden> writes:

> Perhaps var_get_value_cnt could be inline
>
> On Tue, Jun 05, 2007 at 11:27:37PM -0700, address@hidden wrote:
>      Index: merge/src/data/variable.c
>      ===================================================================
>      --- merge.orig/src/data/variable.c       2007-06-03 18:44:51.000000000 
> -0700
>      +++ merge/src/data/variable.c    2007-06-04 21:31:31.000000000 -0700
>      @@ -423,7 +423,7 @@
>       size_t
>       var_get_value_cnt (const struct variable *v) 
>       {
>      -  return v->width == 0 ? 1 : DIV_RND_UP (v->width, MAX_SHORT_STRING);
>      +  return value_cnt_from_width (v->width);
>       }
>       
>       /* Returns variable V's missing values. */

-- 
Ben Pfaff
address@hidden




reply via email to

[Prev in Thread] Current Thread [Next in Thread]