[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[patch #6719] rewrite of interaction.c

From: John Darrington
Subject: [patch #6719] rewrite of interaction.c
Date: Fri, 09 Jan 2009 22:31:43 +0000
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv: Gecko/2008112309 Iceweasel/3.0.4 (Debian-3.0.4-1)

Follow-up Comment #1, patch #6719 (project pspp):

I think its an improvement over the existing version.  I'm beginning to
understand what an "interaction" is now.

Several comments:

0. The copyright notices are 2 years out of date!

1.  If I'm understanding how it's supposed to work, then "struct variable
**members" should be "const struct variable **members" since none of the
members will be modified by the interaction. interaction_variable_create then
should take a const first argument.

2.  Arg 2 of interaction_value_create  should also be const 

3.  Likewise, arg 1 of interaction_variable_get_n_vars 

4. It looks to me as if interaction_value_create is going to cause a buffer
overflow.  result->strings has a width of MAX_SHORT_STRING but you are writing
to it MAX_SHORT_STRING * n_vars bytes + 1 bytes.


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]