[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[patch #6719] rewrite of interaction.c

From: John Darrington
Subject: [patch #6719] rewrite of interaction.c
Date: Mon, 12 Jan 2009 00:39:20 +0000
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv: Gecko/2008112309 Iceweasel/3.0.4 (Debian-3.0.4-1)

Follow-up Comment #5, patch #6719 (project pspp):

Minor gnits:

* interaction.h still has 2007 in the copyright notice.

* Shouldn't interaction_variable_destroy free iv->members ?

* I think arg 1 of interaction_value_create can be const if you also change
intr member of interaction_value to const.

Otherwise I think it's fine.


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]