[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: covariance-matrix.c

From: Jason Stover
Subject: Re: covariance-matrix.c
Date: Tue, 8 Sep 2009 13:59:31 -0400
User-agent: Mutt/1.5.18 (2008-05-17)

On Wed, Sep 09, 2009 at 01:39:10AM +0800, John Darrington wrote:
> covariance_accumulate_listwise doesn't seem to be complete.
> Notably, val2 is used uninitialised.   However, I don't really
> see a need for this function, since it's straightforward, to
> filter missing values on a listwise basis using a casefilter.


> 1. Is covariance_accumulate_listwise actually used? If not, I think
>    it's ok to delete it.

Given your comment above, I agree. My only criticism is that I didn't
think of it first.

> 2. Can we have a way to access ssize?

Yes. I was using such a matrix before, but stopped after it became
unnecessary. It may be time to put it back.

> 3. Has covariance matrix been testing in the presence of non-unity
>    caseweights?  If not, then it ought to be.

I haven't tested that.

> 4. A few extra comments in covariance-matrix.c wouldn't go amiss.

I agree.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]