[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] psppire-acr: Clarify acr ownership of its list store.
From: |
John Darrington |
Subject: |
Re: [PATCH 1/2] psppire-acr: Clarify acr ownership of its list store. |
Date: |
Tue, 24 Apr 2012 19:56:11 +0000 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
On Mon, Apr 23, 2012 at 10:19:05PM -0700, Ben Pfaff wrote:
PsppireAcr retains a pointer to the GtkListStore inside it but it
-/* Set the widget's treemodel */
+/* Set the widget's treemodel to LISTSTORE. LISTSTORE ownership is not
+ transferred. */
void
psppire_acr_set_model (PsppireAcr *acr, GtkListStore *liststore)
{
+ if (acr->list_store)
+ g_object_unref (liststore);
I think there is a typo here ^^^
+ if (liststore)
+ g_object_ref (liststore);
+
acr->list_store = liststore;
--
PGP Public key ID: 1024D/2DE827B3
fingerprint = 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3
See http://keys.gnupg.net or any PGP keyserver for public key.
signature.asc
Description: Digital signature