[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] psppire-acr: Clarify acr ownership of its list store.
From: |
Ben Pfaff |
Subject: |
Re: [PATCH 1/2] psppire-acr: Clarify acr ownership of its list store. |
Date: |
Tue, 24 Apr 2012 22:15:14 -0700 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) |
John Darrington <address@hidden> writes:
> On Mon, Apr 23, 2012 at 10:19:05PM -0700, Ben Pfaff wrote:
> PsppireAcr retains a pointer to the GtkListStore inside it but it
> -/* Set the widget's treemodel */
> +/* Set the widget's treemodel to LISTSTORE. LISTSTORE ownership is not
> + transferred. */
> void
> psppire_acr_set_model (PsppireAcr *acr, GtkListStore *liststore)
> {
> + if (acr->list_store)
> + g_object_unref (liststore);
>
> I think there is a typo here ^^^
Thanks. I changed this to g_object_unref (acr->list_store).