Re: Buffer overrun in parse_mrsets ?

[John Darrington]

I pushed a fix for this.  If you think the fix is wrong, then 
please revert it.

J'

On Sun, Jul 31, 2016 at 06:13:30PM +0200, John Darrington wrote:
     Valgrind is reporting an invalid read in test 117
     
     Is this something we need to fix?
     
     ==3414== Invalid read of size 1
     ==3414==    at 0x52033B2: text_match (sys-file-reader.c:3144)
     ==3414==    by 0x51FFB39: parse_mrsets (sys-file-reader.c:1716)
     ==3414==    by 0x51FC2DF: sfm_open (sys-file-reader.c:427)
     ==3414==    by 0x51CBF2B: any_reader_open (any-reader.c:119)
     ==3414==    by 0x51CC0A3: any_reader_open_and_decode (any-reader.c:169)
     ==3414==    by 0x4EE46E5: parse_read_command (get.c:126)
     ==3414==    by 0x4EE449F: cmd_get (get.c:58)
     ==3414==    by 0x4E64B36: do_parse_command (command.c:233)
     ==3414==    by 0x4E64875: cmd_parse_in_state (command.c:148)
     ==3414==    by 0x4E64940: cmd_parse (command.c:163)
     ==3414==    by 0x4032B1: main (main.c:138)
     ==3414==  Address 0xdad733d is 0 bytes after a block of size 77 alloc'd
     ==3414==    at 0x4C29BCF: malloc (vg_replace_malloc.c:299)
     ==3414==    by 0x524B995: xmalloc (xmalloc.c:41)
     ==3414==    by 0x521F754: pool_malloc (pool.c:471)
     ==3414==    by 0x51FEA1F: read_extension_record (sys-file-reader.c:1349)
     ==3414==    by 0x51FC7CD: read_record (sys-file-reader.c:543)
     ==3414==    by 0x51FC3E0: read_dictionary (sys-file-reader.c:459)
     ==3414==    by 0x51FC2AA: sfm_open (sys-file-reader.c:423)
     ==3414==    by 0x51CBF2B: any_reader_open (any-reader.c:119)
     ==3414==    by 0x51CC0A3: any_reader_open_and_decode (any-reader.c:169)
     ==3414==    by 0x4EE46E5: parse_read_command (get.c:126)
     ==3414==    by 0x4EE449F: cmd_get (get.c:58)
     ==3414==    by 0x4E64B36: do_parse_command (command.c:233)
     ==3414==    by 0x4E64875: cmd_parse_in_state (command.c:148)
     ==3414==    by 0x4E64940: cmd_parse (command.c:163)
     ==3414==    by 0x4032B1: main (main.c:138)
     
     
     -- 
     Avoid eavesdropping.  Send strong encryted email.
     PGP Public key ID: 1024D/2DE827B3 
     fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
     See http://sks-keyservers.net or any PGP keyserver for public key.
     



-- 
Avoid eavesdropping.  Send strong encryted email.
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://sks-keyservers.net or any PGP keyserver for public key.

signature.asc
Description: Digital signature