[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [ELPA] New package: pspp-mode.el for PSPP/SPSS syntax highlighting

From: Vasilij Schneidermann
Subject: Re: [ELPA] New package: pspp-mode.el for PSPP/SPSS syntax highlighting
Date: Tue, 30 Jun 2020 15:07:44 +0200

Hello Friedrich,

> The file is available here:
> Can you integrate that in gnu elpa?

The GNU ELPA Readme [1] explains the necessary steps for this.  One
prerequisite is following the coding style, there's a number of things sticking
out in your code:

- Inconsistent paragraph spacing (sometimes the expected newline is missing,
  sometimes there's two or three of them, with no clear reason why).
- Lone opening/closing parentheses are something to be avoided, please keep
  these together.
- Indentation of comments is inconsistent and doesn't line up with code.
- The major mode definition should use `define-derived-mode`, that way you no
  longer need to manipulate major mode name/hooks/local variables/syntax
  tables/key maps.

All but the last point are elaborated in further detail in Riastradh's Lisp
Style Rules [2].



Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]