qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PULL 14/14] hw/arm/aspeed: Add Fuji machine type


From: Peter Maydell
Subject: Re: [PULL 14/14] hw/arm/aspeed: Add Fuji machine type
Date: Thu, 16 Sep 2021 15:07:12 +0100

On Thu, 16 Sept 2021 at 15:06, Cédric Le Goater <clg@kaod.org> wrote:
> OK. The patch I had prepared was a bit more explicit :
>
>      /* On 32-bit hosts, lower RAM to 1G because of 2047 MB limit */
>      mc->default_ram_size = (HOST_LONG_BITS == 32 ? 1 : 2) * GiB;
>
> I even have a version with a warn_report() since 32-bit hosts are
> not that common these days.

Using warn_report is likely to get the patch bounced because
it adds a new warning to the 'make check' output on 32-bit hosts,
unless you take special care to suppress it when running in qtest...

-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]