[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] d5aebe: docker: Don't use eval trick on Makef
From: |
GitHub |
Subject: |
[Qemu-commits] [qemu/qemu] d5aebe: docker: Don't use eval trick on Makefile |
Date: |
Tue, 07 Jun 2016 07:30:03 -0700 |
Branch: refs/heads/master
Home: https://github.com/qemu/qemu
Commit: d5aebef884cabf197d51d2066a5beee8d0c721d4
https://github.com/qemu/qemu/commit/d5aebef884cabf197d51d2066a5beee8d0c721d4
Author: Eduardo Habkost <address@hidden>
Date: 2016-06-07 (Tue, 07 Jun 2016)
Changed paths:
M tests/docker/Makefile.include
Log Message:
-----------
docker: Don't use eval trick on Makefile
The eval trick for defining DOCKER_SRC_COPY doesn't do anything
useful, as DOCKER_SRC_COPY is immediately expanded just after it
is defined, and CUR_TIME is already defined using ":=". Simply
define it using ":=" so it is evaluated only once.
The eval trick was also triggering an weird error on Travis builds:
qemu/tests/docker/Makefile.include:34: *** unterminated variable reference.
Stop.
The issue is not easily reproducible (maybe it's a bug in some
versions of Make), but it is avoided if removing the eval trick.
Signed-off-by: Eduardo Habkost <address@hidden>
Signed-off-by: Peter Maydell <address@hidden>
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Qemu-commits] [qemu/qemu] d5aebe: docker: Don't use eval trick on Makefile,
GitHub <=