[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] fca9d7: qmp-shell: Sort by key when pretty-pr

From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] fca9d7: qmp-shell: Sort by key when pretty-printing
Date: Thu, 29 Oct 2020 04:32:51 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: fca9d723232a8bc756ca74982ee342f73ebf833c
  Author: David Edmondson <david.edmondson@oracle.com>
  Date:   2020-10-27 (Tue, 27 Oct 2020)

  Changed paths:
    M scripts/qmp/qmp-shell

  Log Message:
  qmp-shell: Sort by key when pretty-printing

If the user selects pretty-printing (-p) the contents of any
dictionaries in the output are sorted by key.

Signed-off-by: David Edmondson <david.edmondson@oracle.com>
Message-Id: <20201013141414.18398-1-david.edmondson@oracle.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>

  Commit: 36006046675228cf2fec904e717d96ca816cc21a
  Author: John Snow <jsnow@redhat.com>
  Date:   2020-10-27 (Tue, 27 Oct 2020)

  Changed paths:
    M scripts/qmp/qmp

  Log Message:
  scripts/qmp: delete 'qmp' script

This script has not seen a patch that was specifically for this script
since it was moved to this location in 2013, and I doubt it is used. It
uses "man qmp" for its help message, which does not exist. It also
presumes there is a manual page for qmp-XXX, for each defined qmp
command XXX. I don't think that's true.

The format it expects arguments in is something like:

block-dirty-bitmap-add --node=foo --name=bar

and has no capacity to support nested JSON arguments, either.

Most developers use either qmp-shell or socat (or pasting JSON directly
into qmp stdio), so this duplication and additional alternate syntax is
not helpful.

Remove it. Leave a breadcrumb script just in case, to be removed next
release cycle.

Signed-off-by: John Snow <jsnow@redhat.com>
Message-Id: <20201019210430.1063390-1-jsnow@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>

  Commit: c0444009147aa935d52d5acfc6b70094bb42b0dd
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2020-10-29 (Thu, 29 Oct 2020)

  Changed paths:
    M scripts/qmp/qmp
    M scripts/qmp/qmp-shell

  Log Message:
  Merge remote-tracking branch 'remotes/armbru/tags/pull-qmp-2020-10-27' into 

QMP patches patches for 2020-10-27

# gpg: Signature made Tue 27 Oct 2020 10:13:00 GMT
# gpg:                using RSA key 354BC8B3D7EB2A6B68674E5F3870B400EB918653
# gpg:                issuer "armbru@redhat.com"
# gpg: Good signature from "Markus Armbruster <armbru@redhat.com>" [full]
# gpg:                 aka "Markus Armbruster <armbru@pond.sub.org>" [full]
# Primary key fingerprint: 354B C8B3 D7EB 2A6B 6867  4E5F 3870 B400 EB91 8653

* remotes/armbru/tags/pull-qmp-2020-10-27:
  scripts/qmp: delete 'qmp' script
  qmp-shell: Sort by key when pretty-printing

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>

Compare: https://github.com/qemu/qemu/compare/a5e7fb4d202e...c0444009147a

reply via email to

[Prev in Thread] Current Thread [Next in Thread]