qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] ab04d2: 9pfs: Fix some return statements in t


From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] ab04d2: 9pfs: Fix some return statements in the synth backend
Date: Wed, 04 Jan 2023 06:54:27 -0800

  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: ab04d2c5579f706893aa014b04296249a0ae8587
      
https://github.com/qemu/qemu/commit/ab04d2c5579f706893aa014b04296249a0ae8587
  Author: Greg Kurz <groug@kaod.org>
  Date:   2022-12-23 (Fri, 23 Dec 2022)

  Changed paths:
    M hw/9pfs/9p-synth.c

  Log Message:
  -----------
  9pfs: Fix some return statements in the synth backend

The qemu_v9fs_synth_mkdir() and qemu_v9fs_synth_add_file() functions
currently return a positive errno value on failure. This causes
checkpatch.pl to spit several errors like the one below:

ERROR: return of an errno should typically be -ve (return -EAGAIN)
+        return EAGAIN;

Simply change the sign. This has no consequence since callers
assert() the returned value to be equal to 0.

Reported-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Greg Kurz <groug@kaod.org>
Message-Id: <166930551818.827792.10663674346122681963.stgit@bahia>
[C.S.: - Resolve conflict with 66997c42e02c. ]
Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>


  Commit: 818e42fe2fad033bfd991096451b9994971852ec
      
https://github.com/qemu/qemu/commit/818e42fe2fad033bfd991096451b9994971852ec
  Author: Christian Schoenebeck <qemu_oss@crudebyte.com>
  Date:   2022-12-23 (Fri, 23 Dec 2022)

  Changed paths:
    M MAINTAINERS

  Log Message:
  -----------
  MAINTAINERS: Add 9p test client to section "virtio-9p"

The 9p test cases use a dedicated, lite-weight 9p client implementation
(using virtio transport) under tests/qtest/libqos/ to communicate with
QEMU's 9p server.

It's already there for a long time. Let's officially assign it to 9p
maintainers.

Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Wilfred Mallawa <wilfred.mallawa@wdc.com>
Message-Id: <E1ozhlV-0007BU-0g@lizzy.crudebyte.com>


  Commit: 6888af46c7849cac8341a32a9da6291270550c5e
      
https://github.com/qemu/qemu/commit/6888af46c7849cac8341a32a9da6291270550c5e
  Author: Bin Meng <bin.meng@windriver.com>
  Date:   2022-12-23 (Fri, 23 Dec 2022)

  Changed paths:
    M include/qemu/xattr.h

  Log Message:
  -----------
  qemu/xattr.h: Exclude <sys/xattr.h> for Windows

Windows does not have <sys/xattr.h>.

Signed-off-by: Bin Meng <bin.meng@windriver.com>
Message-Id: <20221219102022.2167736-2-bin.meng@windriver.com>
Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>


  Commit: 09f0080ecd9238ee1f23414935eead36d5b2b31c
      
https://github.com/qemu/qemu/commit/09f0080ecd9238ee1f23414935eead36d5b2b31c
  Author: Bin Meng <bin.meng@windriver.com>
  Date:   2022-12-23 (Fri, 23 Dec 2022)

  Changed paths:
    M hw/9pfs/9p-util.h

  Log Message:
  -----------
  hw/9pfs: Drop unnecessary *xattr wrapper API declarations

These are not used anywhere in the source tree. Drop them.

Signed-off-by: Bin Meng <bin.meng@windriver.com>
Reviewed-by: Greg Kurz <groug@kaod.org>
Message-Id: <20221219102022.2167736-3-bin.meng@windriver.com>
Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>


  Commit: 6ca60cd7a388a776d72739e5a404e65c19460511
      
https://github.com/qemu/qemu/commit/6ca60cd7a388a776d72739e5a404e65c19460511
  Author: Bin Meng <bin.meng@windriver.com>
  Date:   2022-12-23 (Fri, 23 Dec 2022)

  Changed paths:
    M hw/9pfs/9p-local.c
    M hw/9pfs/9p-util.h

  Log Message:
  -----------
  hw/9pfs: Replace the direct call to xxxat() APIs with a wrapper

xxxat() APIs are only available on POSIX platforms. For future
extension to Windows, let's replace the direct call to xxxat()
APIs with a wrapper.

Signed-off-by: Bin Meng <bin.meng@windriver.com>
Message-Id: <20221219102022.2167736-4-bin.meng@windriver.com>
Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>


  Commit: ecc9a58835f8d4ea4e3ed36832032a71ee08fbb2
      
https://github.com/qemu/qemu/commit/ecc9a58835f8d4ea4e3ed36832032a71ee08fbb2
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2023-01-04 (Wed, 04 Jan 2023)

  Changed paths:
    M MAINTAINERS
    M hw/9pfs/9p-local.c
    M hw/9pfs/9p-synth.c
    M hw/9pfs/9p-util.h
    M include/qemu/xattr.h

  Log Message:
  -----------
  Merge tag 'pull-9p-20221223' of https://github.com/cschoenebeck/qemu into 
staging

9pfs: Windows host prep, cleanup

* Next preparatory patches for upcoming Windows host support.

* Cleanup patches.

# gpg: Signature made Fri 23 Dec 2022 11:04:26 GMT
# gpg:                using RSA key 96D8D110CF7AF8084F88590134C2B58765A47395
# gpg:                issuer "qemu_oss@crudebyte.com"
# gpg: Good signature from "Christian Schoenebeck <qemu_oss@crudebyte.com>" 
[unknown]
# gpg: WARNING: This key is not certified with a trusted signature!
# gpg:          There is no indication that the signature belongs to the owner.
# Primary key fingerprint: ECAB 1A45 4014 1413 BA38  4926 30DB 47C3 A012 D5F4
#      Subkey fingerprint: 96D8 D110 CF7A F808 4F88  5901 34C2 B587 65A4 7395

* tag 'pull-9p-20221223' of https://github.com/cschoenebeck/qemu:
  hw/9pfs: Replace the direct call to xxxat() APIs with a wrapper
  hw/9pfs: Drop unnecessary *xattr wrapper API declarations
  qemu/xattr.h: Exclude <sys/xattr.h> for Windows
  MAINTAINERS: Add 9p test client to section "virtio-9p"
  9pfs: Fix some return statements in the synth backend

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/7f520b12fdbc...ecc9a58835f8



reply via email to

[Prev in Thread] Current Thread [Next in Thread]