[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] gtk: cleanup backend dependencies
|
From: |
Daniel P. Berrange |
|
Subject: |
Re: [Qemu-devel] [PATCH] gtk: cleanup backend dependencies |
|
Date: |
Mon, 2 Jun 2014 12:54:45 +0100 |
|
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Mon, Jun 02, 2014 at 01:50:25PM +0200, Gerd Hoffmann wrote:
> Make configure detect gtk x11 backend and link libX11 then. Make
> gtk backend specific code properly #ifdef'ed on the GTK_WINDOWING_*
> backends at runtime). Our gtk ui code should build and run fine on
> any platform now.
>
> This also fixes the linker failute due to the new XkbGetKeyboard call
> added by commit 3158a3482b0093e41f2b2596fba50774ea31ae08.
>
> Cc: Richard Henderson <address@hidden>
> Signed-off-by: Gerd Hoffmann <address@hidden>
> ---
> configure | 4 +++
> ui/gtk.c | 97
> ++++++++++++++++++++++++++++++++++++---------------------------
> 2 files changed, 60 insertions(+), 41 deletions(-)
Looks good.
Reviewed-by: Daniel P. Berrange <address@hidden>
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|