[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qemu-img: Report error even with --oformat=json
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-devel] [PATCH] qemu-img: Report error even with --oformat=json |
|
Date: |
Mon, 2 Jun 2014 13:59:09 +0200 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 31.05.2014 um 21:33 hat Max Reitz geschrieben:
> img_check() should report that the format of the given image does not
> support checks even if JSON output is desired. JSON data is output to
> stdout, as opposed to error messages, which are (in the case of
> qemu-img) printed to stderr. Therefore, it is easy to distinguish
> between the two.
>
> Also, img_info() does already use error_report() for human-readable
> messages even though JSON output is desired (through
> collect_image_info_list()).
>
> Signed-off-by: Max Reitz <address@hidden>
Thanks, applied to the block branch.
Kevin