[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [patch 1/3] mc146818rtc: add rtc_reset_reinjection QMP
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [patch 1/3] mc146818rtc: add rtc_reset_reinjection QMP command |
Date: |
Mon, 02 Jun 2014 13:31:29 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
On 06/02/2014 11:51 AM, address@hidden wrote:
> It is necessary to reset RTC interrupt reinjection backlog if
> guest time is synchronized via a different mechanism, such as
> QGA's guest-set-time command.
>
> Failing to do so causes both corrections to be applied (summed),
> resulting in an incorrect guest time.
>
> Signed-off-by: Marcelo Tosatti <address@hidden>
>
> Index: qemu/hw/timer/mc146818rtc.c
Still no --- separator between your commit message and the patch body.
Are you using 'git send-email'?
> Index: qemu/qapi-schema.json
> ===================================================================
> --- qemu.orig/qapi-schema.json
> +++ qemu/qapi-schema.json
> @@ -4722,3 +4722,15 @@
> 'btn' : 'InputBtnEvent',
> 'rel' : 'InputMoveEvent',
> 'abs' : 'InputMoveEvent' } }
> +
> +##
> +# @: rtc-reset-reinjection
s/: // to resemble most other commands
> +#
> +# This command will reset RTC's interrupt reinjection backlog.
s/RTC's/the RTC/
> +# Can be used if another mechanism to synchronize guest time
> +# is in effect, for example QEMU guest agents guest-set-time
s/agents/agent's/
> +# command.
> +#
> +# Since: 2.1
> +##
> +{ 'command': 'rtc-reset-reinjection' }
> Index: qemu/qmp-commands.hx
> ===================================================================
> --- qemu.orig/qmp-commands.hx
> +++ qemu/qmp-commands.hx
> @@ -3572,3 +3572,26 @@ Example:
> } } ] }
>
> EQMP
> +
> +#if defined (TARGET_I386)
> + {
> + .name = "rtc_reset_reinjection",
s/rtc_reset_reinjection/rtc-reset-reinjection/
> + .args_type = "",
> + .mhandler.cmd_new = qmp_marshal_input_rtc_reset_reinjection,
> + },
> +#endif
> +
> +SQMP
> +rtc-reset-reinjection
> +---------------------
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature