[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 04/20] target/arm: Rearrange {sve,fp}_check_access assert
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH 04/20] target/arm: Rearrange {sve,fp}_check_access assert |
|
Date: |
Tue, 25 Aug 2020 06:47:05 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 8/24/20 9:59 AM, Peter Maydell wrote:
>> + bool sve_access_checked;
>
> Is there anywhere it's worthwhile to put in an equivalent
> of assert_fp_access_checked() for sve_access_checked, or is
> there no point that's both (a) common to SVE accesses and
> (b) not common to generic FP accesses ? One could put it
> in pred_full_reg_offset() I suppose but I dunno if that
> really gains us much. The existing fp_access_checked will
> catch "forgot the check entirely" which seems more likely
> as a bug than "put in the FP check when we wanted SVE".
While adding one to pred_full_ref_offset() might be useful, there are plenty of
sve instructions that don't touch predicate registers.
I suppose I could make vec_full_reg_offset() be different between
translate-a64.c and translate-sve.c, rather than sharing it via translate-a64.h.
r~
- [PATCH 08/20] target/arm: Split out gen_gvec_ool_zzzp, (continued)
- [PATCH 08/20] target/arm: Split out gen_gvec_ool_zzzp, Richard Henderson, 2020/08/15
- [PATCH 17/20] target/arm: Fix sve_punpk_p vs odd vector lengths, Richard Henderson, 2020/08/15
- [PATCH 19/20] target/arm: Convert integer multiply-add (indexed) to gvec for aa64 advsimd, Richard Henderson, 2020/08/15
- [PATCH 11/20] target/arm: Split out gen_gvec_ool_zzz, Richard Henderson, 2020/08/15
- [PATCH 04/20] target/arm: Rearrange {sve,fp}_check_access assert, Richard Henderson, 2020/08/15
- [PATCH 15/20] target/arm: Fix sve_uzp_p vs odd vector lengths, Richard Henderson, 2020/08/15
- [PATCH 10/20] target/arm: Split out gen_gvec_ool_zzp, Richard Henderson, 2020/08/15
- [PATCH 05/20] target/arm: Merge do_vector2_p into do_mov_p, Richard Henderson, 2020/08/15
- [PATCH 14/20] target/arm: Generalize inl_qrdmlah_* helper functions, Richard Henderson, 2020/08/15