qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 1/6] meson: Fixes the ninjatool issue that E$$: are genera


From: Yonggang Luo
Subject: Re: [PATCH v5 1/6] meson: Fixes the ninjatool issue that E$$: are generated in Makefile.ninja
Date: Wed, 26 Aug 2020 23:31:11 +0800

I can tell you build.ninja can contains $: symbol, that's the escape for Ninja,
when ninjatool parse it, it will convert $: -> :, so that's not a problem.
This is part of the build.ninja on my computer

```
build version.rc_version.o: CUSTOM_COMMAND_DEP ../qemu.org/version.rc | C$:/CI-Tools/msys64/mingw64/bin/x86_64-w64-mingw32-windres.EXE ../qemu.org/pc-bios/qemu-nsis.ico
 DEPFILE = "version.rc_version.o.d"
 DEPFILE_UNQUOTED = version.rc_version.o.d
 COMMAND = "C:/CI-Tools/msys64/mingw64/bin/x86_64-w64-mingw32-windres.EXE" "-I./." "-I../qemu.org/." "../qemu.org/version.rc" "version.rc_version.o" "--preprocessor-arg=-MD" "--preprocessor-arg=-MQversion.rc_version.o" "--preprocessor-arg=-MFversion.rc_version.o.d"
 description = Generating$ Windows$ resource$ for$ file$ 'version.rc'$ with$ a$ custom$ command
```

On Wed, Aug 26, 2020 at 11:28 PM Paolo Bonzini <pbonzini@redhat.com> wrote:
On Wed, Aug 26, 2020 at 5:12 PM <luoyonggang@gmail.com> wrote:
>
> From: Yonggang Luo <luoyonggang@gmail.com>
>
> SIMPLE_PATH_RE should match the full path token.
> Or the $ and : contained in path would not matched if the path are start with C:/ and E:/

I don't understand this, SIMPLE_PATH_RE is used with re.match which
only matches at the beginning of the string. Can you send me your
build.ninja file offlist?

Thanks,

Paolo



--
         此致

罗勇刚
Yours
    sincerely,
Yonggang Luo

reply via email to

[Prev in Thread] Current Thread [Next in Thread]