Re: [PATCH v5 1/6] meson: Fixes the ninjatool issue that E$$: are generated in Makefile.ninja

[Paolo Bonzini]

On Wed, Aug 26, 2020 at 5:31 PM 罗勇刚(Yonggang Luo) <luoyonggang@gmail.com> wrote:
>
> I can tell you build.ninja can contains $: symbol, that's the escape for 
> Ninja,
> when ninjatool parse it, it will convert $: -> :, so that's not a problem.
> This is part of the build.ninja on my computer

Ok, that's useful. But can you just send the whole file (it's huge but
you can gzip it or something similar)?

Paolo

> ```
> build version.rc_version.o: CUSTOM_COMMAND_DEP ../qemu.org/version.rc | 
> C$:/CI-Tools/msys64/mingw64/bin/x86_64-w64-mingw32-windres.EXE 
> ../qemu.org/pc-bios/qemu-nsis.ico
>  DEPFILE = "version.rc_version.o.d"
>  DEPFILE_UNQUOTED = version.rc_version.o.d
>  COMMAND = "C:/CI-Tools/msys64/mingw64/bin/x86_64-w64-mingw32-windres.EXE" 
> "-I./." "-I../qemu.org/." "../qemu.org/version.rc" "version.rc_version.o" 
> "--preprocessor-arg=-MD" "--preprocessor-arg=-MQversion.rc_version.o" 
> "--preprocessor-arg=-MFversion.rc_version.o.d"
>  description = Generating$ Windows$ resource$ for$ file$ 'version.rc'$ with$ 
> a$ custom$ command
> ```
>
> On Wed, Aug 26, 2020 at 11:28 PM Paolo Bonzini <pbonzini@redhat.com> wrote:
>>
>> On Wed, Aug 26, 2020 at 5:12 PM <luoyonggang@gmail.com> wrote:
>> >
>> > From: Yonggang Luo <luoyonggang@gmail.com>
>> >
>> > SIMPLE_PATH_RE should match the full path token.
>> > Or the $ and : contained in path would not matched if the path are start 
>> > with C:/ and E:/
>>
>> I don't understand this, SIMPLE_PATH_RE is used with re.match which
>> only matches at the beginning of the string. Can you send me your
>> build.ninja file offlist?
>>
>> Thanks,
>>
>> Paolo
>>
>
>
> --
>          此致
> 礼
> 罗勇刚
> Yours
>     sincerely,
> Yonggang Luo