[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] meson: move pixman detection to meson
|
From: |
Thomas Huth |
|
Subject: |
Re: [PATCH] meson: move pixman detection to meson |
|
Date: |
Thu, 27 Aug 2020 09:28:14 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 |
On 27/08/2020 08.14, Paolo Bonzini wrote:
>
>
> Il gio 27 ago 2020, 06:53 Thomas Huth <thuth@redhat.com
> <mailto:thuth@redhat.com>> ha scritto:
>
> > -else
> > - error_exit "pixman >= 0.21.8 not present." \
> > - "Please install the pixman devel package."
> > -fi
>
> The "else" part now got completely lost, didn't it?
>
>
> It's replaced by "required: have_system" in meson.build. We can add a
> custom "not found" message, but if the current one is not enough we
> should improve Meson so that it figures out a good one from the version
> requirement.
Ah, now it makes sense, thanks for the explanation!
But I've tested the patch now, and it does not work:
.../qemu/meson.build:117:3: ERROR: Unknown variable "have_system".
Should the pixman test maybe be moved to a later spot in the file? It
currently shows up before the have_system variable is initialized...
Thomas