Re: [PATCH] meson: move pixman detection to meson

[Stefan Weil]

Am 26.08.20 um 09:02 schrieb Paolo Bonzini:

> When pixman is not installed (or too old), but virglrenderer is available
> and "configure" has been run with "--disable-system", the build currently
> aborts when trying to compile vhost-user-gpu (since it requires pixman).
>
> Let's skip the build of vhost-user-gpu when pixman is not installed or
> too old.  Instead of adding CONFIG_PIXMAN, it is simpler to move the
> detection to pixman.
>
> Based on a patch by Thomas Huth. <thuth@redhat.com>


I don't know whether this is related to these patches, but I observe a
failing build with pixman. A build which was configured with
--enable-debug and --enable-modules currently terminates with this error
message:

Compiling C object libui-curses.a.p/ui_curses.c.o
In file included from
/home/stefan/src/qemu/qemu.org/qemu/include/ui/console.h:4,
                 from ../ui/curses.c:38:
/home/stefan/src/qemu/qemu.org/qemu/include/ui/qemu-pixman.h:12:10:
fatal error: pixman.h: No such file or directory
   12 | #include <pixman.h>
      |          ^~~~~~~~~~
compilation terminated.

The same error also occurs for two more compilations when I run make -k:

Compiling C object libui-spice-app.a.p/ui_spice-app.c.o
[...]
Compiling C object libchardev-baum.a.p/chardev_baum.c.o
[...]

Obviously the compiler flags which are required for pixman-1
(-I/usr/include/pixman-1) are not passed to the compiler.

A build without --enable-modules does not show these errors. Are there
already CI tests with --enable-modules?

Regards,

Stefan