Re: [PATCH] cirrus.yml: Exclude some targets in the FreeBSD job to speed up the build

[Thomas Huth]

On 27/08/2020 17.00, Daniel P. Berrangé wrote:
> On Mon, Aug 24, 2020 at 11:44:10AM +0200, Thomas Huth wrote:
>> The FreeBSD jobs currently hit the 1h time limit in the Cirrus-CI.
>> We've got to exclude some build targets here to make sure that the job
>> finishes in time again. The targets that are excluded should not hurt
>> much, since e.g. all the code from i386-softmmu is covered again by
>> x86_64-softmmu.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>>  Not sure why the FreeBSD builds suddenly got slower and hit the 1h
>>  time limit now. Looking at https://cirrus-ci.com/github/qemu/qemu
>>  it seems like the FreeBSD jobs were already taking ca. 48 minutes
>>  since quite a while, but since the Meson build system has been merged,
>>  they now always hit the 1h limit. Could it be that Meson is slow on
>>  FreeBSD?
> 
> No, it appears to just be compiling a lot more than in the past.
> 
> $ grep Compiling main.log-meson  | wc -l
> 5468
> 
> $ grep CC main.log-config  | wc -l
> 4855

Oh, that's interesting, thanks!

> This seems to be caused my compiling lots of stuff under tests/
> that we did not previously build
> 
> $ grep Compiling main.log-meson  | grep tests/ | wc -l
> 616
> 
> not sure if this is specific to FreeBSD, or whether we're doing
> this on all platforms and merely noticed first on FreeBSD due
> to the timeout.

I also did some build time tests on my x86 Linux laptop, but I did not
notice any significant differences there.

> Mostly it seems to the libtestfloat ad libsoftfloat, but also
> a bit of libqtest stuff.

Now that you've mentioned softfloat ... I think that matches what I've
seen in the log output on cirrus-ci.com : Suddenly there is a lot of
verbose softloat test output there that I never noticed before.

I assume that's ok that we now compile/test more on FreeBSD, so I'll go
ahead with this patch and put it into my next "CI" pull
request to fix the cirrus-ci builds again.

 Thomas