Re: [PATCH v4 7/7] Versal: Connect DWC3 controller with virt-versal

[Gerd Hoffmann]

  Hi,

> +        unsigned int irq = VERSAL_USB0_IRQ_0;
> +        const char intName[] = "dwc_usb3";
> +        qemu_fdt_setprop(s->fdt, name, "interrupt-names",
> +                         intName, sizeof(intName));
> +        qemu_fdt_setprop_cells(s->fdt, name, "interrupts",
> +                                   GIC_FDT_IRQ_TYPE_SPI, irq,
> +                                   GIC_FDT_IRQ_FLAGS_LEVEL_HI);

This seems to declare one IRQ in the FDT.

> +    qdev_prop_set_uint32(xhci_dev, "intrs", 4);

Here you configure 4 IRQs for xhci-sysbus.

> +    sysbus_connect_irq(SYS_BUS_DEVICE(xhci_dev), 0, pic[VERSAL_USB0_IRQ_0]);

Also a single IRQ only.

I'm wondering which is correct?  Probably one IRQ?  Do we need support
for multiple IRQs in xhci-sysbus in the first place?

take care,
  Gerd