[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 01/10] qga/channel-posix: Plug memory leak in ga_channel_write
From: |
Pan Nengyuan |
Subject: |
[PATCH v2 01/10] qga/channel-posix: Plug memory leak in ga_channel_write_all() |
Date: |
Mon, 31 Aug 2020 09:43:06 -0400 |
Missing g_error_free on error path in ga_channel_write_all(). Fix that.
Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Pan Nengyuan <pannengyuan@huawei.com>
Reviewed-by: Li Qiang <liq3ea@gmail.com>
---
Cc: Michael Roth <mdroth@linux.vnet.ibm.com>
---
- V2: no changes in v2
---
qga/channel-posix.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/qga/channel-posix.c b/qga/channel-posix.c
index 8fc205ad21..0b151cb87b 100644
--- a/qga/channel-posix.c
+++ b/qga/channel-posix.c
@@ -249,7 +249,7 @@ GIOStatus ga_channel_write_all(GAChannel *c, const gchar
*buf, gsize size)
buf += written;
} else if (status != G_IO_STATUS_AGAIN) {
g_warning("error writing to channel: %s", err->message);
- return status;
+ goto out;
}
}
@@ -261,6 +261,10 @@ GIOStatus ga_channel_write_all(GAChannel *c, const gchar
*buf, gsize size)
g_warning("error flushing channel: %s", err->message);
}
+out:
+ if (err) {
+ g_error_free(err);
+ }
return status;
}
--
2.18.2
- [PATCH v2 00/10] fix some error memleaks, Pan Nengyuan, 2020/08/31
- [PATCH v2 01/10] qga/channel-posix: Plug memory leak in ga_channel_write_all(),
Pan Nengyuan <=
- [PATCH v2 04/10] target/i386/sev: Plug memleak in sev_read_file_base64, Pan Nengyuan, 2020/08/31
- [PATCH v2 07/10] migration/colo: Plug memleaks in colo_process_incoming_thread, Pan Nengyuan, 2020/08/31
- [PATCH v2 03/10] elf2dmp/pdb: Plug memleak in pdb_init_from_file, Pan Nengyuan, 2020/08/31
- [PATCH v2 06/10] target/i386/cpu: Fix memleak in x86_cpu_class_check_missing_features, Pan Nengyuan, 2020/08/31
- [PATCH v2 09/10] block/file-posix: fix a possible undefined behavior, Pan Nengyuan, 2020/08/31
- [PATCH v2 08/10] blockdev: Fix a memleak in drive_backup_prepare(), Pan Nengyuan, 2020/08/31
- [PATCH v2 10/10] vnc-auth-sasl: Plug memleak in vnc_socket_ip_addr_string, Pan Nengyuan, 2020/08/31
- [PATCH v2 02/10] elf2dmp/qemu_elf: Plug memleak in QEMU_Elf_init, Pan Nengyuan, 2020/08/31
- [PATCH v2 05/10] ui/gtk-gl-area: Plug memleak in gd_gl_area_create_context(), Pan Nengyuan, 2020/08/31