[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 34/44] hw/arm/omap1:Remove redundant statement in omap_clkdsp_read
From: |
Laurent Vivier |
Subject: |
[PULL 34/44] hw/arm/omap1:Remove redundant statement in omap_clkdsp_read() |
Date: |
Tue, 1 Sep 2020 16:09:44 +0200 |
From: Chen Qun <kuhn.chenqun@huawei.com>
Clang static code analyzer show warning:
hw/arm/omap1.c:1760:15: warning: Value stored to 'cpu' during its
initialization is never read
CPUState *cpu = CPU(s->cpu);
^~~ ~~~~~~~~~~~
Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Li Qiang <liq3ea@gmail.com>
Message-Id: <20200827110311.164316-3-kuhn.chenqun@huawei.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
hw/arm/omap1.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/arm/omap1.c b/hw/arm/omap1.c
index 6ba0df6b6d09..02c0f66431b9 100644
--- a/hw/arm/omap1.c
+++ b/hw/arm/omap1.c
@@ -1774,7 +1774,6 @@ static uint64_t omap_clkdsp_read(void *opaque, hwaddr
addr,
return s->clkm.dsp_rstct2;
case 0x18: /* DSP_SYSST */
- cpu = CPU(s->cpu);
return (s->clkm.clocking_scheme << 11) | s->clkm.cold_start |
(cpu->halted << 6); /* Quite useless... */
}
--
2.26.2
- [PULL 07/44] hw: Remove superfluous breaks, (continued)
- [PULL 07/44] hw: Remove superfluous breaks, Laurent Vivier, 2020/09/01
- [PULL 24/44] docs/system/target-avr: Improve the AVR docs and add to MAINTAINERS, Laurent Vivier, 2020/09/01
- [PULL 05/44] vnc: Remove the superfluous break, Laurent Vivier, 2020/09/01
- [PULL 06/44] block/vmdk: Remove superfluous breaks, Laurent Vivier, 2020/09/01
- [PULL 32/44] linux-user: Add strace support for printing OFD fcntl operations, Laurent Vivier, 2020/09/01
- [PULL 21/44] util/qemu-timer: Fix typo in description, Laurent Vivier, 2020/09/01
- [PULL 26/44] hw/ide/ahci: Replace magic '512' value by BDRV_SECTOR_SIZE, Laurent Vivier, 2020/09/01
- [PULL 09/44] target/cris: Remove superfluous breaks, Laurent Vivier, 2020/09/01
- [PULL 28/44] hw/ide/pci: Replace magic '512' value by BDRV_SECTOR_SIZE, Laurent Vivier, 2020/09/01
- [PULL 27/44] hw/ide/atapi: Replace magic '512' value by BDRV_SECTOR_SIZE, Laurent Vivier, 2020/09/01
- [PULL 34/44] hw/arm/omap1:Remove redundant statement in omap_clkdsp_read(),
Laurent Vivier <=
- [PULL 43/44] main-loop: Fix comment, Laurent Vivier, 2020/09/01
- [PULL 35/44] target/arm/translate-a64:Remove dead assignment in handle_scalar_simd_shli(), Laurent Vivier, 2020/09/01
- [PULL 44/44] docs/system: Fix grammar in documentation, Laurent Vivier, 2020/09/01
- [PULL 38/44] hw/net/virtio-net:Remove redundant statement in virtio_net_rsc_tcp_ctrl_check(), Laurent Vivier, 2020/09/01
- [PULL 41/44] hw/intc: fix default registers value in exynos4210_combiner_read(), Laurent Vivier, 2020/09/01
- [PULL 29/44] hw/scsi/scsi-disk: Replace magic '512' value by BDRV_SECTOR_SIZE, Laurent Vivier, 2020/09/01
- [PULL 37/44] hw/virtio/vhost-user:Remove dead assignment in scrub_shadow_regions(), Laurent Vivier, 2020/09/01
- [PULL 25/44] hw/ide/core: Trivial typo fix, Laurent Vivier, 2020/09/01
- [PULL 40/44] usb/bus: Remove dead assignment in usb_get_fw_dev_path(), Laurent Vivier, 2020/09/01
- [PULL 42/44] hw/display/vga:Remove redundant statement in vga_draw_graphic(), Laurent Vivier, 2020/09/01