[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 41/44] hw/intc: fix default registers value in exynos4210_combiner
From: |
Laurent Vivier |
Subject: |
[PULL 41/44] hw/intc: fix default registers value in exynos4210_combiner_read() |
Date: |
Tue, 1 Sep 2020 16:09:51 +0200 |
From: Chen Qun <kuhn.chenqun@huawei.com>
Clang static code analyzer show warning:
hw/intc/exynos4210_combiner.c:231:9: warning: Value stored to 'val' is never
read
val = s->reg_set[offset >> 2];
The default register return value should be return 'val'.
Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Message-Id: <20200827110311.164316-10-kuhn.chenqun@huawei.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
hw/intc/exynos4210_combiner.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/intc/exynos4210_combiner.c b/hw/intc/exynos4210_combiner.c
index b8561e418037..59dd27fb16e5 100644
--- a/hw/intc/exynos4210_combiner.c
+++ b/hw/intc/exynos4210_combiner.c
@@ -229,7 +229,6 @@ exynos4210_combiner_read(void *opaque, hwaddr offset,
unsigned size)
TARGET_FMT_plx "offset\n", offset);
}
val = s->reg_set[offset >> 2];
- return 0;
}
return val;
}
--
2.26.2
- [PULL 21/44] util/qemu-timer: Fix typo in description, (continued)
- [PULL 21/44] util/qemu-timer: Fix typo in description, Laurent Vivier, 2020/09/01
- [PULL 26/44] hw/ide/ahci: Replace magic '512' value by BDRV_SECTOR_SIZE, Laurent Vivier, 2020/09/01
- [PULL 09/44] target/cris: Remove superfluous breaks, Laurent Vivier, 2020/09/01
- [PULL 28/44] hw/ide/pci: Replace magic '512' value by BDRV_SECTOR_SIZE, Laurent Vivier, 2020/09/01
- [PULL 27/44] hw/ide/atapi: Replace magic '512' value by BDRV_SECTOR_SIZE, Laurent Vivier, 2020/09/01
- [PULL 34/44] hw/arm/omap1:Remove redundant statement in omap_clkdsp_read(), Laurent Vivier, 2020/09/01
- [PULL 43/44] main-loop: Fix comment, Laurent Vivier, 2020/09/01
- [PULL 35/44] target/arm/translate-a64:Remove dead assignment in handle_scalar_simd_shli(), Laurent Vivier, 2020/09/01
- [PULL 44/44] docs/system: Fix grammar in documentation, Laurent Vivier, 2020/09/01
- [PULL 38/44] hw/net/virtio-net:Remove redundant statement in virtio_net_rsc_tcp_ctrl_check(), Laurent Vivier, 2020/09/01
- [PULL 41/44] hw/intc: fix default registers value in exynos4210_combiner_read(),
Laurent Vivier <=
- [PULL 29/44] hw/scsi/scsi-disk: Replace magic '512' value by BDRV_SECTOR_SIZE, Laurent Vivier, 2020/09/01
- [PULL 37/44] hw/virtio/vhost-user:Remove dead assignment in scrub_shadow_regions(), Laurent Vivier, 2020/09/01
- [PULL 25/44] hw/ide/core: Trivial typo fix, Laurent Vivier, 2020/09/01
- [PULL 40/44] usb/bus: Remove dead assignment in usb_get_fw_dev_path(), Laurent Vivier, 2020/09/01
- [PULL 42/44] hw/display/vga:Remove redundant statement in vga_draw_graphic(), Laurent Vivier, 2020/09/01
- [PULL 22/44] util/vfio-helpers: Fix typo in description, Laurent Vivier, 2020/09/01
- [PULL 30/44] hw/net/xilinx_axienet: Remove unused code, Laurent Vivier, 2020/09/01
- [PULL 31/44] util/vfio-helpers: Unify trace-events size format, Laurent Vivier, 2020/09/01
- [PULL 36/44] target/arm/translate-a64:Remove redundant statement in disas_simd_two_reg_misc_fp16(), Laurent Vivier, 2020/09/01
- [PULL 33/44] hw/arm/virt-acpi-build:Remove dead assignment in build_madt(), Laurent Vivier, 2020/09/01