[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 28/63] tusb6010: Rename TYPE_TUSB6010 to TYPE_TUSB
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH 28/63] tusb6010: Rename TYPE_TUSB6010 to TYPE_TUSB |
Date: |
Thu, 3 Sep 2020 14:56:20 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
On 9/3/20 12:42 AM, Eduardo Habkost wrote:
> This will make the type name constant consistent with the name of
> the type checking macro.
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: qemu-devel@nongnu.org
> ---
> hw/usb/tusb6010.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/hw/usb/tusb6010.c b/hw/usb/tusb6010.c
> index 2bee3ae59f..9b35c1d4b8 100644
> --- a/hw/usb/tusb6010.c
> +++ b/hw/usb/tusb6010.c
> @@ -30,10 +30,10 @@
> #include "hw/sysbus.h"
> #include "qom/object.h"
>
> -#define TYPE_TUSB6010 "tusb6010"
> +#define TYPE_TUSB "tusb6010"
We are loosing information helpful to reviewers.
Can we rename the type macro TUSB6010() instead?
> typedef struct TUSBState TUSBState;
> DECLARE_INSTANCE_CHECKER(TUSBState, TUSB,
> - TYPE_TUSB6010)
> + TYPE_TUSB)
>
> struct TUSBState {
> SysBusDevice parent_obj;
> @@ -838,7 +838,7 @@ static void tusb6010_class_init(ObjectClass *klass, void
> *data)
> }
>
> static const TypeInfo tusb6010_info = {
> - .name = TYPE_TUSB6010,
> + .name = TYPE_TUSB,
> .parent = TYPE_SYS_BUS_DEVICE,
> .instance_size = sizeof(TUSBState),
> .class_init = tusb6010_class_init,
>
- [PATCH 21/63] pxb: Rename TYPE_PXB_DEVICE to TYPE_PXB_DEV, (continued)
- [PATCH 21/63] pxb: Rename TYPE_PXB_DEVICE to TYPE_PXB_DEV, Eduardo Habkost, 2020/09/02
- [PATCH 22/63] pxb: Rename TYPE_PXB_PCIE_DEVICE to TYPE_PXB_PCIE_DEV, Eduardo Habkost, 2020/09/02
- [PATCH 23/63] ramfb: Rename TYPE_RAMFB_DEVICE to TYPE_RAMFB, Eduardo Habkost, 2020/09/02
- [PATCH 24/63] scsi: Rename TYPE_AM53C974_DEVICE to TYPE_PCI_ESP, Eduardo Habkost, 2020/09/02
- [PATCH 25/63] scsi: Rename TYPE_DC390_DEVICE to TYPE_DC390, Eduardo Habkost, 2020/09/02
- [PATCH 27/63] sun4u: Rename TYPE_SUN4U_MEMORY to TYPE_SUN4U_RAM, Eduardo Habkost, 2020/09/02
- [PATCH 26/63] sun4m: Rename TYPE_SUN4M_MEMORY to TYPE_SUN4M_RAM, Eduardo Habkost, 2020/09/02
- [PATCH 28/63] tusb6010: Rename TYPE_TUSB6010 to TYPE_TUSB, Eduardo Habkost, 2020/09/02
- Re: [PATCH 28/63] tusb6010: Rename TYPE_TUSB6010 to TYPE_TUSB,
Philippe Mathieu-Daudé <=
- [PATCH 29/63] versatile: Rename TYPE_VERSATILE_PCI_HOST to TYPE_PCI_VPB_HOST, Eduardo Habkost, 2020/09/02
- [PATCH 30/63] versatile: Rename TYPE_VERSATILE_PCI to TYPE_PCI_VPB, Eduardo Habkost, 2020/09/02
- [PATCH 31/63] virtio-console: Rename TYPE_VIRTIO_CONSOLE_SERIAL_PORT to TYPE_VIRTIO_CONSOLE, Eduardo Habkost, 2020/09/02
- [PATCH 33/63] net/can: Rename TYPE_CAN_CPI constants, Eduardo Habkost, 2020/09/02
- [PATCH 34/63] can: Rename KVASER_PCI_DEV to KVASER_PCI, Eduardo Habkost, 2020/09/02
- [PATCH 35/63] can: Rename MIOe3680_PCI_DEV to MIOE3680_PCI, Eduardo Habkost, 2020/09/02
- [PATCH 32/63] ahci: Rename ICH_AHCI to ICH9_AHCI, Eduardo Habkost, 2020/09/02