[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 33/63] net/can: Rename TYPE_CAN_CPI constants
From: |
Eduardo Habkost |
Subject: |
Re: [PATCH 33/63] net/can: Rename TYPE_CAN_CPI constants |
Date: |
Thu, 3 Sep 2020 12:35:13 -0400 |
On Thu, Sep 03, 2020 at 02:59:00PM +0200, Philippe Mathieu-Daudé wrote:
> On 9/3/20 12:42 AM, Eduardo Habkost wrote:
> > Rename macros to names that are unique in the source tree, to
> > reduce confusion and make automated conversion of the code
> > easier.
> >
> > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> > ---
> > Cc: Jason Wang <jasowang@redhat.com>
> > Cc: qemu-devel@nongnu.org
> > ---
> > hw/net/can/can_kvaser_pci.c | 6 +++---
> > hw/net/can/can_mioe3680_pci.c | 6 +++---
> > hw/net/can/can_pcm3680_pci.c | 6 +++---
> > 3 files changed, 9 insertions(+), 9 deletions(-)
> >
> > diff --git a/hw/net/can/can_kvaser_pci.c b/hw/net/can/can_kvaser_pci.c
> > index 168b3a620d..12d4f8df33 100644
> > --- a/hw/net/can/can_kvaser_pci.c
> > +++ b/hw/net/can/can_kvaser_pci.c
> > @@ -45,11 +45,11 @@
> > #include "can_sja1000.h"
> > #include "qom/object.h"
> >
> > -#define TYPE_CAN_PCI_DEV "kvaser_pci"
> > +#define TYPE_KVASER_PCI "kvaser_pci"
>
> Why keep "PCI" and not keep the "CAN" part?
> To be consistent we should use both busses or none.
Because the type name is "kvaser_pci", the device state struct is
called KVaserPCIState, the type checking macro is called
KVASER_PCI_DEV, and most functions inside that file are called
kvaser_pci_*().
--
Eduardo
- [PATCH 27/63] sun4u: Rename TYPE_SUN4U_MEMORY to TYPE_SUN4U_RAM, (continued)
- [PATCH 27/63] sun4u: Rename TYPE_SUN4U_MEMORY to TYPE_SUN4U_RAM, Eduardo Habkost, 2020/09/02
- [PATCH 26/63] sun4m: Rename TYPE_SUN4M_MEMORY to TYPE_SUN4M_RAM, Eduardo Habkost, 2020/09/02
- [PATCH 28/63] tusb6010: Rename TYPE_TUSB6010 to TYPE_TUSB, Eduardo Habkost, 2020/09/02
- [PATCH 29/63] versatile: Rename TYPE_VERSATILE_PCI_HOST to TYPE_PCI_VPB_HOST, Eduardo Habkost, 2020/09/02
- [PATCH 30/63] versatile: Rename TYPE_VERSATILE_PCI to TYPE_PCI_VPB, Eduardo Habkost, 2020/09/02
- [PATCH 31/63] virtio-console: Rename TYPE_VIRTIO_CONSOLE_SERIAL_PORT to TYPE_VIRTIO_CONSOLE, Eduardo Habkost, 2020/09/02
- [PATCH 33/63] net/can: Rename TYPE_CAN_CPI constants, Eduardo Habkost, 2020/09/02
- [PATCH 34/63] can: Rename KVASER_PCI_DEV to KVASER_PCI, Eduardo Habkost, 2020/09/02
- [PATCH 35/63] can: Rename MIOe3680_PCI_DEV to MIOE3680_PCI, Eduardo Habkost, 2020/09/02
- [PATCH 32/63] ahci: Rename ICH_AHCI to ICH9_AHCI, Eduardo Habkost, 2020/09/02
- [PATCH 36/63] can: Rename PCM3680i_PCI_DEV to PCM3680_PCI, Eduardo Habkost, 2020/09/02
- [PATCH 37/63] ccid-card-emulated: Rename EMULATED_CCID_CARD to EMULATED_CCID, Eduardo Habkost, 2020/09/02
- [PATCH 38/63] ccid-card-passthru: Rename PASSTHRU_CCID_CARD to CCID_PASSTHRU, Eduardo Habkost, 2020/09/02
- [PATCH 39/63] esp: Rename ESP_STATE to ESP, Eduardo Habkost, 2020/09/02