[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 39/63] esp: Rename ESP_STATE to ESP
From: |
Eduardo Habkost |
Subject: |
Re: [PATCH 39/63] esp: Rename ESP_STATE to ESP |
Date: |
Thu, 3 Sep 2020 12:36:48 -0400 |
On Thu, Sep 03, 2020 at 03:01:33PM +0200, Philippe Mathieu-Daudé wrote:
> On 9/3/20 12:42 AM, Eduardo Habkost wrote:
> > Make the type checking macro name consistent with the TYPE_*
> > constant.
> >
> > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> > ---
> > Cc: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> > Cc: Laurent Vivier <laurent@vivier.eu>
> > Cc: "Hervé Poussineau" <hpoussin@reactos.org>
> > Cc: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>
> > Cc: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
> > Cc: Aurelien Jarno <aurelien@aurel32.net>
> > Cc: Jiaxun Yang <jiaxun.yang@flygoat.com>
> > Cc: Paolo Bonzini <pbonzini@redhat.com>
> > Cc: Fam Zheng <fam@euphon.net>
> > Cc: Artyom Tarasenko <atar4qemu@gmail.com>
> > Cc: qemu-devel@nongnu.org
> > ---
> > include/hw/scsi/esp.h | 2 +-
> > hw/dma/sparc32_dma.c | 2 +-
> > hw/m68k/q800.c | 2 +-
> > hw/mips/jazz.c | 2 +-
> > hw/scsi/esp.c | 6 +++---
> > hw/sparc/sun4m.c | 2 +-
> > 6 files changed, 8 insertions(+), 8 deletions(-)
> >
> > diff --git a/include/hw/scsi/esp.h b/include/hw/scsi/esp.h
> > index f281625dd5..20800dbf5b 100644
> > --- a/include/hw/scsi/esp.h
> > +++ b/include/hw/scsi/esp.h
> > @@ -67,7 +67,7 @@ struct ESPState {
> >
> > #define TYPE_ESP "esp"
> > typedef struct SysBusESPState SysBusESPState;
> > -DECLARE_INSTANCE_CHECKER(SysBusESPState, ESP_STATE,
> > +DECLARE_INSTANCE_CHECKER(SysBusESPState, ESP,
> > TYPE_ESP)
>
> "ESPDMA" would less likely clash with eventual 'ESP' definition.
I want to make the changes less intrusive as possible. If the
macro is already called ESP and the type name string is already
"esp", I will just keep the existing naming.
--
Eduardo
- [PATCH 34/63] can: Rename KVASER_PCI_DEV to KVASER_PCI, (continued)
- [PATCH 34/63] can: Rename KVASER_PCI_DEV to KVASER_PCI, Eduardo Habkost, 2020/09/02
- [PATCH 35/63] can: Rename MIOe3680_PCI_DEV to MIOE3680_PCI, Eduardo Habkost, 2020/09/02
- [PATCH 32/63] ahci: Rename ICH_AHCI to ICH9_AHCI, Eduardo Habkost, 2020/09/02
- [PATCH 36/63] can: Rename PCM3680i_PCI_DEV to PCM3680_PCI, Eduardo Habkost, 2020/09/02
- [PATCH 37/63] ccid-card-emulated: Rename EMULATED_CCID_CARD to EMULATED_CCID, Eduardo Habkost, 2020/09/02
- [PATCH 38/63] ccid-card-passthru: Rename PASSTHRU_CCID_CARD to CCID_PASSTHRU, Eduardo Habkost, 2020/09/02
- [PATCH 39/63] esp: Rename ESP_STATE to ESP, Eduardo Habkost, 2020/09/02
- [PATCH 41/63] lance: Rename SYSBUS_PCNET to LANCE, Eduardo Habkost, 2020/09/02
- [PATCH 40/63] filter-rewriter: Rename FILTER_COLO_REWRITER to FILTER_REWRITER, Eduardo Habkost, 2020/09/02
- [PATCH 42/63] lasi_i82596: Rename SYSBUS_I82596 to LASI_82596, Eduardo Habkost, 2020/09/02
- [PATCH 43/63] pvpanic: Rename ISA_PVPANIC_DEVICE to PVPANIC, Eduardo Habkost, 2020/09/02
- [PATCH 44/63] renesas: Rename RCMT to RENESAS_CMT, Eduardo Habkost, 2020/09/02
- [PATCH 46/63] renesas: Rename RTMR to RENESAS_TMR, Eduardo Habkost, 2020/09/02
- [PATCH 45/63] renesas: Rename RSCI to RENESAS_SCI, Eduardo Habkost, 2020/09/02
- [PATCH 47/63] rs6000_mc: Rename RS6000MC_DEVICE to RS6000MC, Eduardo Habkost, 2020/09/02