[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/7] scripts/ci/gitlab-pipeline-status: improve message regar
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH 2/7] scripts/ci/gitlab-pipeline-status: improve message regarding timeout |
Date: |
Fri, 4 Sep 2020 18:53:06 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
On 9/4/20 6:42 PM, Cleber Rosa wrote:
> The script has its own timeout, which is about how long the script
> will wait (when called with --wait) for the pipeline to complete, and
> not necessarily for the pipeline to complete.
>
> Hopefully this will new wording will be clearer.
too many wills?
>
> Signed-off-by: Cleber Rosa <crosa@redhat.com>
> ---
> scripts/ci/gitlab-pipeline-status | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/ci/gitlab-pipeline-status
> b/scripts/ci/gitlab-pipeline-status
> index 194dd4d0bb..2a36f74696 100755
> --- a/scripts/ci/gitlab-pipeline-status
> +++ b/scripts/ci/gitlab-pipeline-status
> @@ -69,7 +69,10 @@ def wait_on_pipeline_success(timeout, interval,
> start = time.time()
> while True:
> if time.time() >= (start + timeout):
> - print("Waiting on the pipeline timed out")
> + msg = ("Timeout (-t/--timeout) of %i seconds reached, "
> + "won't wait any longer for the pipeline to complete")
> + msg %= timeout
> + print(msg)
Isn't it more pythonic / cheaper to declare the msg format out
of the loop and call directly:
print(msg % timeout)
?
> return False
>
> status = get_pipeline_status(project_id, commit_sha)
>
- [PATCH 0/7] gitlab pipeline check/watch script improvements, Cleber Rosa, 2020/09/04
- [PATCH 2/7] scripts/ci/gitlab-pipeline-status: improve message regarding timeout, Cleber Rosa, 2020/09/04
- Re: [PATCH 2/7] scripts/ci/gitlab-pipeline-status: improve message regarding timeout,
Philippe Mathieu-Daudé <=
- [PATCH 3/7] scripts/ci/gitlab-pipeline-status: give early feedback on running pipelines, Cleber Rosa, 2020/09/04
- [PATCH 6/7] scripts/ci/gitlab-pipeline-status: use more descriptive exceptions, Cleber Rosa, 2020/09/04
- [PATCH 7/7] scripts/ci/gitlab-pipeline-status: wait for pipeline creation, Cleber Rosa, 2020/09/04
- [PATCH 4/7] scripts/ci/gitlab-pipeline-status: refactor parser creation, Cleber Rosa, 2020/09/04
- [PATCH 1/7] scripts/ci/gitlab-pipeline-status: make branch name configurable, Cleber Rosa, 2020/09/04
- [PATCH 5/7] scripts/ci/gitlab-pipeline-status: handle keyboard interrupts, Cleber Rosa, 2020/09/04