[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/7] scripts/ci/gitlab-pipeline-status: give early feedback o
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH 3/7] scripts/ci/gitlab-pipeline-status: give early feedback on running pipelines |
Date: |
Fri, 4 Sep 2020 18:59:24 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
On 9/4/20 6:42 PM, Cleber Rosa wrote:
> When waiting for a pipeline to run and finish, it's better to give
> early feedback, and then sleep and wait, than the other wait around.
>
> Specially for the first iteration, it's frustrating to see nothing
> while the script is sleeping.
>
> Signed-off-by: Cleber Rosa <crosa@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> scripts/ci/gitlab-pipeline-status | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/ci/gitlab-pipeline-status
> b/scripts/ci/gitlab-pipeline-status
> index 2a36f74696..18609553be 100755
> --- a/scripts/ci/gitlab-pipeline-status
> +++ b/scripts/ci/gitlab-pipeline-status
> @@ -77,8 +77,8 @@ def wait_on_pipeline_success(timeout, interval,
>
> status = get_pipeline_status(project_id, commit_sha)
> if status['status'] == 'running':
> - time.sleep(interval)
> print('running...')
> + time.sleep(interval)
> continue
>
> if status['status'] == 'success':
>
- [PATCH 0/7] gitlab pipeline check/watch script improvements, Cleber Rosa, 2020/09/04
- [PATCH 2/7] scripts/ci/gitlab-pipeline-status: improve message regarding timeout, Cleber Rosa, 2020/09/04
- [PATCH 3/7] scripts/ci/gitlab-pipeline-status: give early feedback on running pipelines, Cleber Rosa, 2020/09/04
- Re: [PATCH 3/7] scripts/ci/gitlab-pipeline-status: give early feedback on running pipelines,
Philippe Mathieu-Daudé <=
- [PATCH 6/7] scripts/ci/gitlab-pipeline-status: use more descriptive exceptions, Cleber Rosa, 2020/09/04
- [PATCH 7/7] scripts/ci/gitlab-pipeline-status: wait for pipeline creation, Cleber Rosa, 2020/09/04
- [PATCH 4/7] scripts/ci/gitlab-pipeline-status: refactor parser creation, Cleber Rosa, 2020/09/04
- [PATCH 1/7] scripts/ci/gitlab-pipeline-status: make branch name configurable, Cleber Rosa, 2020/09/04
- [PATCH 5/7] scripts/ci/gitlab-pipeline-status: handle keyboard interrupts, Cleber Rosa, 2020/09/04