[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 6/8] tests/meson.build: fp tests don't need CONFIG_TCG
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v1 6/8] tests/meson.build: fp tests don't need CONFIG_TCG |
Date: |
Mon, 7 Sep 2020 11:41:00 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
On 9/7/20 11:11 AM, Alex Bennée wrote:
>
> Paolo Bonzini <pbonzini@redhat.com> writes:
>
>> Il gio 3 set 2020, 13:21 Alex Bennée <alex.bennee@linaro.org> ha scritto:
>>
>>> As the tests build only softfloat.c no actual TCG machinary is neede
>>> to test them (as is evidenced by GCC check-softfloat). Might as well
>>> fix the wording on Travis while at it.
>>>
>>
>> The reason is that softfloat is not built at all into QEMU if !CONFIG_TCG.
>> We similarly skip block layer tests if !CONFIG_SOFTMMU &&
>> !CONFIG_TOOLS.
>
> It's not built anyway if you don't call the test. Are you saying a
> --disable-system and --disable-user build is invalid for running unit
> tests? That is what check-softfloat is doing as it doesn't involve
> softfloat built into any qemu binary.
FYI my tools build dir is configured as:
'--enable-trace-backends=log' '--disable-docs' '--enable-debug'
'--disable-system' '--disable-user' '--enable-tools'
and it still works after the Meson conversion.
>
>>
>> Paolo
>>
>>
>>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>>> ---
>>> .travis.yml | 2 +-
>>> tests/meson.build | 3 ++-
>>> 2 files changed, 3 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/.travis.yml b/.travis.yml
>>> index 1d0ade0a133..65341634d02 100644
>>> --- a/.travis.yml
>>> +++ b/.travis.yml
>>> @@ -138,7 +138,7 @@ jobs:
>>>
>>>
>>> # Just build tools and run minimal unit and softfloat checks
>>> - - name: "GCC check-softfloat (user)"
>>> + - name: "GCC check-unit and check-softfloat"
>>> env:
>>> - BASE_CONFIG="--enable-tools"
>>> - CONFIG="--disable-user --disable-system"
>>> diff --git a/tests/meson.build b/tests/meson.build
>>> index fe2c6d8e6b6..bdcc5d75293 100644
>>> --- a/tests/meson.build
>>> +++ b/tests/meson.build
>>> @@ -7,8 +7,9 @@ test('decodetree', sh,
>>> workdir: meson.current_source_dir() / 'decode',
>>> suite: 'decodetree')
>>>
>>> +subdir('fp')
>>> +
>>> if 'CONFIG_TCG' in config_host
>>> - subdir('fp')
>>> if 'CONFIG_PLUGIN' in config_host
>>> subdir('plugin')
>>> endif
>>> --
>>> 2.20.1
>>>
>>>
>
>
[PATCH v1 7/8] target/mips: simplify gen_compute_imm_branch logic, Alex Bennée, 2020/09/03
Re: [PATCH v1 0/8] some testing and CI updates (re-greening), Daniel P . Berrangé, 2020/09/03