[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 6/8] tests/meson.build: fp tests don't need CONFIG_TCG
From: |
Alex Bennée |
Subject: |
Re: [PATCH v1 6/8] tests/meson.build: fp tests don't need CONFIG_TCG |
Date: |
Mon, 07 Sep 2020 10:55:05 +0100 |
User-agent: |
mu4e 1.5.5; emacs 28.0.50 |
Philippe Mathieu-Daudé <philmd@redhat.com> writes:
> On 9/7/20 11:11 AM, Alex Bennée wrote:
>>
>> Paolo Bonzini <pbonzini@redhat.com> writes:
>>
>>> Il gio 3 set 2020, 13:21 Alex Bennée <alex.bennee@linaro.org> ha scritto:
>>>
>>>> As the tests build only softfloat.c no actual TCG machinary is neede
>>>> to test them (as is evidenced by GCC check-softfloat). Might as well
>>>> fix the wording on Travis while at it.
>>>>
>>>
>>> The reason is that softfloat is not built at all into QEMU if !CONFIG_TCG.
>>> We similarly skip block layer tests if !CONFIG_SOFTMMU &&
>>> !CONFIG_TOOLS.
>>
>> It's not built anyway if you don't call the test. Are you saying a
>> --disable-system and --disable-user build is invalid for running unit
>> tests? That is what check-softfloat is doing as it doesn't involve
>> softfloat built into any qemu binary.
>
> FYI my tools build dir is configured as:
>
> '--enable-trace-backends=log' '--disable-docs' '--enable-debug'
> '--disable-system' '--disable-user' '--enable-tools'
>
> and it still works after the Meson conversion.
But check-softfloat doesn't work with that right?
--
Alex Bennée
[PATCH v1 7/8] target/mips: simplify gen_compute_imm_branch logic, Alex Bennée, 2020/09/03
Re: [PATCH v1 0/8] some testing and CI updates (re-greening), Daniel P . Berrangé, 2020/09/03