[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 11/16] meson: disable crypto tests are empty under win32
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH 11/16] meson: disable crypto tests are empty under win32 |
Date: |
Wed, 9 Sep 2020 09:10:21 +0100 |
User-agent: |
Mutt/1.14.6 (2020-07-11) |
On Wed, Sep 09, 2020 at 03:48:15AM +0800, Yonggang Luo wrote:
> Disable following tests on msys2/mingw
> 'test-crypto-tlscredsx509': ['crypto-tls-x509-helpers.c',
> 'pkix_asn1_tab.c',
> tasn1, crypto],
> 'test-crypto-tlssession': ['crypto-tls-x509-helpers.c',
> 'pkix_asn1_tab.c', 'crypto-tls-psk-helpers.c',
> tasn1, crypto],
> 'test-io-channel-tls': ['io-channel-helpers.c',
> 'crypto-tls-x509-helpers.c', 'pkix_asn1_tab.c',
> tasn1, io, crypto]}
Why ? GNUTLS is available on Windows and if it is enabled
at build time, then we should certainly be running the tests.
>
> Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
> ---
> tests/meson.build | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/meson.build b/tests/meson.build
> index 998e4c48f9..b470a90e3a 100644
> --- a/tests/meson.build
> +++ b/tests/meson.build
> @@ -145,7 +145,8 @@ if have_block
> 'test-crypto-block': [io],
> }
> if 'CONFIG_GNUTLS' in config_host and \
> - 'CONFIG_TASN1' in config_host
> + 'CONFIG_TASN1' in config_host and \
> + 'CONFIG_POSIX' in config_host
> tests += {
> 'test-crypto-tlscredsx509': ['crypto-tls-x509-helpers.c',
> 'pkix_asn1_tab.c',
> tasn1, crypto],
> --
> 2.28.0.windows.1
>
>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- Re: [PATCH 06/16] ci: Enable msys2 ci in cirrus, (continued)
- [PATCH 07/16] tests: Trying fixes test-replication.c on msys2/mingw., Yonggang Luo, 2020/09/08
- [PATCH 08/16] block: get file-win32.c handle locking option consistence with file-posix.c, Yonggang Luo, 2020/09/08
- [PATCH 09/16] osdep: These function are only available on Non-Win32 system., Yonggang Luo, 2020/09/08
- [PATCH 10/16] meson: Use -b to ignore CR vs. CR-LF issues on Windows, Yonggang Luo, 2020/09/08
- [PATCH 11/16] meson: disable crypto tests are empty under win32, Yonggang Luo, 2020/09/08
[PATCH 12/16] meson: remove empty else and duplicated gio deps, Yonggang Luo, 2020/09/08
[PATCH 13/16] vmstate: Fixes test-vmstate.c on msys2/mingw, Yonggang Luo, 2020/09/08
[PATCH 14/16] cirrus: Building freebsd in a single short, Yonggang Luo, 2020/09/08