[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 13/16] vmstate: Fixes test-vmstate.c on msys2/mingw
From: |
Thomas Huth |
Subject: |
Re: [PATCH 13/16] vmstate: Fixes test-vmstate.c on msys2/mingw |
Date: |
Wed, 9 Sep 2020 10:11:09 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 |
On 08/09/2020 21.48, Yonggang Luo wrote:
> The vmstate are valid on win32, just need generate tmp path properly
>
> Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> tests/test-vmstate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c
> index f8de709a0b..4c453575bb 100644
> --- a/tests/test-vmstate.c
> +++ b/tests/test-vmstate.c
> @@ -34,7 +34,6 @@
> #include "qemu/module.h"
> #include "io/channel-file.h"
>
> -static char temp_file[] = "/tmp/vmst.test.XXXXXX";
> static int temp_fd;
>
>
> @@ -1487,6 +1486,7 @@ static void test_tmp_struct(void)
>
> int main(int argc, char **argv)
> {
> + g_autofree char* temp_file = g_strdup_printf("%s/vmst.test.XXXXXX",
> g_get_tmp_dir());
> temp_fd = mkstemp(temp_file);
>
> module_call_init(MODULE_INIT_QOM);
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
- [PATCH 10/16] meson: Use -b to ignore CR vs. CR-LF issues on Windows, (continued)
[PATCH 12/16] meson: remove empty else and duplicated gio deps, Yonggang Luo, 2020/09/08
[PATCH 13/16] vmstate: Fixes test-vmstate.c on msys2/mingw, Yonggang Luo, 2020/09/08
- Re: [PATCH 13/16] vmstate: Fixes test-vmstate.c on msys2/mingw,
Thomas Huth <=
[PATCH 14/16] cirrus: Building freebsd in a single short, Yonggang Luo, 2020/09/08
[PATCH 15/16] logging: Fixes memory leak in test-logging.c, Yonggang Luo, 2020/09/08
[PATCH 16/16] rcu: add uninit destructor for rcu, Yonggang Luo, 2020/09/08
Re: [PATCH 00/16] W32, W64 patches, Eric Blake, 2020/09/08