[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 1/8] qemu-options: New -compat to set policy for deprecate
From: |
Markus Armbruster |
Subject: |
Re: [PATCH v5 1/8] qemu-options: New -compat to set policy for deprecated interfaces |
Date: |
Mon, 21 Sep 2020 16:35:40 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Peter Krempa <pkrempa@redhat.com> writes:
> On Mon, Sep 14, 2020 at 10:47:55 +0200, Markus Armbruster wrote:
>> Policy is separate for input and output.
>>
>> Input policy can be "accept" (accept silently), or "reject" (reject
>> the request with an error).
>>
>> Output policy can be "accept" (pass on unchanged), or "hide" (filter
>> out the deprecated parts).
>>
>> Default is "accept". Policies other than "accept" are implemented
>> later in this series.
>>
>> For now, -compat covers only syntactic aspects of QMP, i.e. stuff
>> tagged with feature 'deprecated'. We may want to extend it to cover
>> semantic aspects, CLI, and experimental features.
>>
>> The option is experimental.
>>
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>
> I wasn't able to find any good anchor point which would allow me to
> detect that this command line option/feature is present.
>
> Is there anything in e.g. in query-qmp-schema or query-command-line-options
> I could base this capability on?
You asked this in review of v4. I didn't have a ready answer then, and
forgot to figure out a solution before I post v5. Thanks for the
reminder!
- Re: [PATCH v5 4/8] qapi: Implement deprecated-output=hide for QMP event data, (continued)
- [PATCH v5 3/8] qapi: Implement deprecated-output=hide for QMP events, Markus Armbruster, 2020/09/14
- [PATCH v5 6/8] qapi: Implement deprecated-input=reject for QMP commands, Markus Armbruster, 2020/09/14
- [PATCH v5 5/8] qapi: Implement deprecated-output=hide for QMP introspection, Markus Armbruster, 2020/09/14
- [PATCH v5 1/8] qemu-options: New -compat to set policy for deprecated interfaces, Markus Armbruster, 2020/09/14
- [PATCH v5 8/8] qapi: New -compat deprecated-input=crash, Markus Armbruster, 2020/09/14
- [PATCH v5 7/8] qapi: Implement deprecated-input=reject for QMP command arguments, Markus Armbruster, 2020/09/14
- [PATCH v5 2/8] qapi: Implement deprecated-output=hide for QMP command results, Markus Armbruster, 2020/09/14
- Re: [PATCH v5 0/8] Configurable policy for handling deprecated interfaces, Richard W.M. Jones, 2020/09/21