[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 8/8] qapi: New -compat deprecated-input=crash
From: |
Markus Armbruster |
Subject: |
Re: [PATCH v5 8/8] qapi: New -compat deprecated-input=crash |
Date: |
Mon, 21 Sep 2020 16:42:25 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Eric Blake <eblake@redhat.com> writes:
> On 9/14/20 3:48 AM, Markus Armbruster wrote:
>> Policy "crash" calls abort() when deprecated input is received.
>> Bugs in integration tests may mask the error from policy "reject".
>> Provide a larger hammer: crash outright. Masking that seems unlikely.
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>
>> +++ b/qemu-options.hx
>> @@ -3392,7 +3392,7 @@ DEFHEADING()
>> DEFHEADING(Debug/Expert options:)
>> DEF("compat", HAS_ARG, QEMU_OPTION_compat,
>> - "-compat
>> [deprecated-input=accept|reject][,deprecated-output=accept|hide]\n"
>> + "-compat
>> [deprecated-input=accept|reject|crash][,deprecated-output=accept|hide]\n"
>> " Policy for handling deprecated management
>> interfaces\n",
>> QEMU_ARCH_ALL)
>> SRST
>> @@ -3403,6 +3403,8 @@ SRST
>> Accept deprecated commands and arguments
>> ``deprecated-input=reject``
>> Reject deprecated commands and arguments
>> + ``deprecated-input=crash``
>> + Crash on deprecated command
>
> Missing 'and arguments'?
Yes.
> Otherwise,
> Reviewed-by: Eric Blake <eblake@redhat.com>
Thanks!
- [PATCH v5 5/8] qapi: Implement deprecated-output=hide for QMP introspection, (continued)
- [PATCH v5 5/8] qapi: Implement deprecated-output=hide for QMP introspection, Markus Armbruster, 2020/09/14
- [PATCH v5 1/8] qemu-options: New -compat to set policy for deprecated interfaces, Markus Armbruster, 2020/09/14
- [PATCH v5 8/8] qapi: New -compat deprecated-input=crash, Markus Armbruster, 2020/09/14
- [PATCH v5 7/8] qapi: Implement deprecated-input=reject for QMP command arguments, Markus Armbruster, 2020/09/14
- [PATCH v5 2/8] qapi: Implement deprecated-output=hide for QMP command results, Markus Armbruster, 2020/09/14
- Re: [PATCH v5 0/8] Configurable policy for handling deprecated interfaces, Richard W.M. Jones, 2020/09/21
- Re: [PATCH v5 0/8] Configurable policy for handling deprecated interfaces, Peter Maydell, 2020/09/21