[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 20/24] machine: Register "memory-backend" as class property
From: |
Igor Mammedov |
Subject: |
Re: [PATCH 20/24] machine: Register "memory-backend" as class property |
Date: |
Tue, 22 Sep 2020 08:39:54 +0200 |
On Mon, 21 Sep 2020 18:10:41 -0400
Eduardo Habkost <ehabkost@redhat.com> wrote:
> Class properties make QOM introspection simpler and easier, as
> they don't require an object to be instantiated.
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> Cc: Eduardo Habkost <ehabkost@redhat.com>
> Cc: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
> Cc: qemu-devel@nongnu.org
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
> ---
> hw/core/machine.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/hw/core/machine.c b/hw/core/machine.c
> index ea26d612374..675ca6d651c 100644
> --- a/hw/core/machine.c
> +++ b/hw/core/machine.c
> @@ -874,6 +874,12 @@ static void machine_class_init(ObjectClass *oc, void
> *data)
> machine_get_memory_encryption, machine_set_memory_encryption);
> object_class_property_set_description(oc, "memory-encryption",
> "Set memory encryption object to use");
> +
> + object_class_property_add_str(oc, "memory-backend",
> + machine_get_memdev, machine_set_memdev);
> + object_class_property_set_description(oc, "memory-backend",
> + "Set RAM backend"
> + "Valid value is ID of hostmem
> based backend");
> }
>
> static void machine_class_base_init(ObjectClass *oc, void *data)
> @@ -925,12 +931,6 @@ static void machine_initfn(Object *obj)
> "Table (HMAT)");
> }
>
> - object_property_add_str(obj, "memory-backend",
> - machine_get_memdev, machine_set_memdev);
> - object_property_set_description(obj, "memory-backend",
> - "Set RAM backend"
> - "Valid value is ID of hostmem based
> backend");
> -
> /* Register notifier when init is done for sysbus sanity checks */
> ms->sysbus_notifier.notify = machine_init_notify;
> qemu_add_machine_init_done_notifier(&ms->sysbus_notifier);
- Re: [PATCH 19/24] xlnx-zcu102: Register properties as class properties, (continued)
- [PATCH 15/24] arm/virt: Register most properties as class properties, Eduardo Habkost, 2020/09/21
- [PATCH 16/24] virt: Register "its" as class property, Eduardo Habkost, 2020/09/21
- [PATCH 21/24] vga-pci: Register "big-endian-framebuffer" as class property, Eduardo Habkost, 2020/09/21
- [PATCH 23/24] sifive_e: Register "revb" as class property, Eduardo Habkost, 2020/09/21
- [PATCH 17/24] cpu/core: Register core-id and nr-threads as class properties, Eduardo Habkost, 2020/09/21
- [PATCH 18/24] arm/cpu64: Register "aarch64" as class property, Eduardo Habkost, 2020/09/21
- [PATCH 20/24] machine: Register "memory-backend" as class property, Eduardo Habkost, 2020/09/21
- Re: [PATCH 20/24] machine: Register "memory-backend" as class property,
Igor Mammedov <=
- [PATCH 24/24] sifive_u: Register "start-in-flash" as class property, Eduardo Habkost, 2020/09/21
- [PATCH 22/24] i440fx: Register i440FX-pcihost properties as class properties, Eduardo Habkost, 2020/09/21
- Re: [PATCH 00/24] qom: Convert some properties to class properties, Li Qiang, 2020/09/21
- Re: [PATCH 00/24] qom: Convert some properties to class properties, no-reply, 2020/09/21
- Re: [PATCH 00/24] qom: Convert some properties to class properties, Eduardo Habkost, 2020/09/22