[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 17/24] cpu/core: Register core-id and nr-threads as class pro
From: |
Igor Mammedov |
Subject: |
Re: [PATCH 17/24] cpu/core: Register core-id and nr-threads as class properties |
Date: |
Tue, 22 Sep 2020 08:48:36 +0200 |
On Mon, 21 Sep 2020 18:10:38 -0400
Eduardo Habkost <ehabkost@redhat.com> wrote:
> Class properties make QOM introspection simpler and easier, as
> they don't require an object to be instantiated.
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
> ---
> Cc: qemu-devel@nongnu.org
> ---
> hw/cpu/core.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/hw/cpu/core.c b/hw/cpu/core.c
> index 3a659291eae..92d3b2fbad6 100644
> --- a/hw/cpu/core.c
> +++ b/hw/cpu/core.c
> @@ -69,10 +69,6 @@ static void cpu_core_instance_init(Object *obj)
> MachineState *ms = MACHINE(qdev_get_machine());
> CPUCore *core = CPU_CORE(obj);
>
> - object_property_add(obj, "core-id", "int", core_prop_get_core_id,
> - core_prop_set_core_id, NULL, NULL);
> - object_property_add(obj, "nr-threads", "int", core_prop_get_nr_threads,
> - core_prop_set_nr_threads, NULL, NULL);
> core->nr_threads = ms->smp.threads;
> }
>
> @@ -81,6 +77,10 @@ static void cpu_core_class_init(ObjectClass *oc, void
> *data)
> DeviceClass *dc = DEVICE_CLASS(oc);
>
> set_bit(DEVICE_CATEGORY_CPU, dc->categories);
> + object_class_property_add(oc, "core-id", "int", core_prop_get_core_id,
> + core_prop_set_core_id, NULL, NULL);
> + object_class_property_add(oc, "nr-threads", "int",
> core_prop_get_nr_threads,
> + core_prop_set_nr_threads, NULL, NULL);
> }
>
> static const TypeInfo cpu_core_type_info = {
- Re: [PATCH 14/24] i386: Register feature bit properties as class properties, (continued)
- [PATCH 19/24] xlnx-zcu102: Register properties as class properties, Eduardo Habkost, 2020/09/21
- [PATCH 15/24] arm/virt: Register most properties as class properties, Eduardo Habkost, 2020/09/21
- [PATCH 16/24] virt: Register "its" as class property, Eduardo Habkost, 2020/09/21
- [PATCH 21/24] vga-pci: Register "big-endian-framebuffer" as class property, Eduardo Habkost, 2020/09/21
- [PATCH 23/24] sifive_e: Register "revb" as class property, Eduardo Habkost, 2020/09/21
- [PATCH 17/24] cpu/core: Register core-id and nr-threads as class properties, Eduardo Habkost, 2020/09/21
- Re: [PATCH 17/24] cpu/core: Register core-id and nr-threads as class properties,
Igor Mammedov <=
- [PATCH 18/24] arm/cpu64: Register "aarch64" as class property, Eduardo Habkost, 2020/09/21
- [PATCH 20/24] machine: Register "memory-backend" as class property, Eduardo Habkost, 2020/09/21
- [PATCH 24/24] sifive_u: Register "start-in-flash" as class property, Eduardo Habkost, 2020/09/21
- [PATCH 22/24] i440fx: Register i440FX-pcihost properties as class properties, Eduardo Habkost, 2020/09/21
- Re: [PATCH 00/24] qom: Convert some properties to class properties, Li Qiang, 2020/09/21
- Re: [PATCH 00/24] qom: Convert some properties to class properties, no-reply, 2020/09/21