[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 27/31] nbd: Deprecate nbd-server-add/remove
From: |
Kevin Wolf |
Subject: |
[PATCH v2 27/31] nbd: Deprecate nbd-server-add/remove |
Date: |
Thu, 24 Sep 2020 17:27:13 +0200 |
These QMP commands are replaced by block-export-add/del.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
qapi/block-export.json | 11 +++++++++--
docs/system/deprecated.rst | 6 ++++++
2 files changed, 15 insertions(+), 2 deletions(-)
diff --git a/qapi/block-export.json b/qapi/block-export.json
index ad01e9f8aa..2291d6cb0c 100644
--- a/qapi/block-export.json
+++ b/qapi/block-export.json
@@ -108,13 +108,16 @@
#
# The export name will be used as the id for the resulting block export.
#
+# Features:
+# @deprecated: This command is deprecated. Use @block-export-add instead.
+#
# Returns: error if the server is not running, or export with the same name
# already exists.
#
# Since: 1.3.0
##
{ 'command': 'nbd-server-add',
- 'data': 'NbdServerAddOptions', 'boxed': true }
+ 'data': 'NbdServerAddOptions', 'boxed': true, 'features': ['deprecated'] }
##
# @BlockExportRemoveMode:
@@ -147,6 +150,9 @@
# @mode: Mode of command operation. See @BlockExportRemoveMode description.
# Default is 'safe'.
#
+# Features:
+# @deprecated: This command is deprecated. Use @block-export-del instead.
+#
# Returns: error if
# - the server is not running
# - export is not found
@@ -155,7 +161,8 @@
# Since: 2.12
##
{ 'command': 'nbd-server-remove',
- 'data': {'name': 'str', '*mode': 'BlockExportRemoveMode'} }
+ 'data': {'name': 'str', '*mode': 'BlockExportRemoveMode'},
+ 'features': ['deprecated'] }
##
# @nbd-server-stop:
diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst
index 808c334fe7..71276c08f3 100644
--- a/docs/system/deprecated.rst
+++ b/docs/system/deprecated.rst
@@ -303,6 +303,12 @@ chardev client socket with ``wait`` option (since 4.0)
Character devices creating sockets in client mode should not specify
the 'wait' field, which is only applicable to sockets in server mode
+``nbd-server-add`` and ``nbd-server-remove`` (since 5.2)
+''''''''''''''''''''''''''''''''''''''''''''''''''''''''
+
+Use the more generic commands ``block-export-add`` and ``block-export-del``
+instead.
+
Human Monitor Protocol (HMP) commands
-------------------------------------
--
2.25.4
- [PATCH v2 21/31] block/export: Add BLOCK_EXPORT_DELETED event, (continued)
- [PATCH v2 21/31] block/export: Add BLOCK_EXPORT_DELETED event, Kevin Wolf, 2020/09/24
- [PATCH v2 18/31] block/export: Add 'id' option to block-export-add, Kevin Wolf, 2020/09/24
- [PATCH v2 25/31] block/export: Move writable to BlockExportOptions, Kevin Wolf, 2020/09/24
- [PATCH v2 23/31] block/export: Create BlockBackend in blk_exp_add(), Kevin Wolf, 2020/09/24
- [PATCH v2 24/31] block/export: Add query-block-exports, Kevin Wolf, 2020/09/24
- [PATCH v2 26/31] nbd: Merge nbd_export_new() and nbd_export_create(), Kevin Wolf, 2020/09/24
- [PATCH v2 30/31] iotests: Allow supported and unsupported formats at the same time, Kevin Wolf, 2020/09/24
- [PATCH v2 27/31] nbd: Deprecate nbd-server-add/remove,
Kevin Wolf <=
- [PATCH v2 29/31] iotests: Introduce qemu_nbd_list_log(), Kevin Wolf, 2020/09/24
- [PATCH v2 28/31] iotests: Factor out qemu_tool_pipe_and_status(), Kevin Wolf, 2020/09/24
- [PATCH v2 31/31] iotests: Test block-export-* QMP interface, Kevin Wolf, 2020/09/24
- Re: [PATCH v2 00/31] block/export: Add infrastructure and QAPI for block exports, no-reply, 2020/09/24
- Re: [PATCH v2 00/31] block/export: Add infrastructure and QAPI for block exports, Stefan Hajnoczi, 2020/09/25