[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 26/31] nbd: Merge nbd_export_new() and nbd_export_create()
From: |
Max Reitz |
Subject: |
Re: [PATCH v2 26/31] nbd: Merge nbd_export_new() and nbd_export_create() |
Date: |
Fri, 25 Sep 2020 14:42:34 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
On 24.09.20 17:27, Kevin Wolf wrote:
> There is no real reason any more why nbd_export_new() and
> nbd_export_create() should be separate functions. The latter only
> performs a few checks before it calls the former.
>
> What makes the current state stand out is that it's the only function in
> BlockExportDriver that is not a static function inside nbd/server.c, but
> a small wrapper in blockdev-nbd.c that then calls back into nbd/server.c
> for the real functionality.
Thanks :)
signature.asc
Description: OpenPGP digital signature
- [PATCH v2 17/31] block/export: Add blk_exp_close_all(_type), (continued)
- [PATCH v2 17/31] block/export: Add blk_exp_close_all(_type), Kevin Wolf, 2020/09/24
- [PATCH v2 20/31] block/export: Add block-export-del, Kevin Wolf, 2020/09/24
- [PATCH v2 22/31] block/export: Move blk to BlockExport, Kevin Wolf, 2020/09/24
- [PATCH v2 21/31] block/export: Add BLOCK_EXPORT_DELETED event, Kevin Wolf, 2020/09/24
- [PATCH v2 18/31] block/export: Add 'id' option to block-export-add, Kevin Wolf, 2020/09/24
- [PATCH v2 25/31] block/export: Move writable to BlockExportOptions, Kevin Wolf, 2020/09/24
- [PATCH v2 23/31] block/export: Create BlockBackend in blk_exp_add(), Kevin Wolf, 2020/09/24
- [PATCH v2 24/31] block/export: Add query-block-exports, Kevin Wolf, 2020/09/24
- [PATCH v2 26/31] nbd: Merge nbd_export_new() and nbd_export_create(), Kevin Wolf, 2020/09/24
- Re: [PATCH v2 26/31] nbd: Merge nbd_export_new() and nbd_export_create(),
Max Reitz <=
- [PATCH v2 30/31] iotests: Allow supported and unsupported formats at the same time, Kevin Wolf, 2020/09/24
- [PATCH v2 27/31] nbd: Deprecate nbd-server-add/remove, Kevin Wolf, 2020/09/24
- [PATCH v2 29/31] iotests: Introduce qemu_nbd_list_log(), Kevin Wolf, 2020/09/24
- [PATCH v2 28/31] iotests: Factor out qemu_tool_pipe_and_status(), Kevin Wolf, 2020/09/24
- [PATCH v2 31/31] iotests: Test block-export-* QMP interface, Kevin Wolf, 2020/09/24