[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 5/8] qemu/bswap: Use compiler __builtin_bswap() on Haiku
From: |
Thomas Huth |
Subject: |
Re: [PATCH v2 5/8] qemu/bswap: Use compiler __builtin_bswap() on Haiku |
Date: |
Mon, 28 Sep 2020 19:29:55 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 |
On 28/09/2020 15.19, Philippe Mathieu-Daudé wrote:
> Since commit efc6c070aca ("configure: Add a test for the minimum
> compiler version") the minimum compiler version required for GCC
> is 4.8, which supports __builtin_bswap().
> Remove the Haiku specific ifdef'ry.
>
> This reverts commit 652a46ebba970017c7a23767dcc983265cdb8eb7
> ("bswap.h: Include <endian.h> on Haiku for bswap operations").
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> Cc: David Carlier <devnexen@gmail.com>
> Cc: Carlo Arenas <carenas@gmail.com>
> ---
> include/qemu/bswap.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/qemu/bswap.h b/include/qemu/bswap.h
> index 55916670d39..719d620bfe6 100644
> --- a/include/qemu/bswap.h
> +++ b/include/qemu/bswap.h
> @@ -8,8 +8,6 @@
> # include <machine/bswap.h>
> #elif defined(__FreeBSD__)
> # include <sys/endian.h>
> -#elif defined(__HAIKU__)
> -# include <endian.h>
> #else
> #undef bswap16
> #define bswap16(_x) __builtin_bswap16(_x)
Why don't we simply always use the builtin functions on all systems? I
assume the compiler can handle these the best in all cases... or do you
see any advantage in using <machine/bswap.h> or <sys/endian.h> in
certain cases?
Thomas
Thomas
- [PATCH v2 1/8] qemu/bswap: Remove unused qemu_bswap_len(), (continued)
- [PATCH v2 1/8] qemu/bswap: Remove unused qemu_bswap_len(), Philippe Mathieu-Daudé, 2020/09/28
- [PATCH v2 2/8] qemu/bswap: Replace bswapXX() by compiler __builtin_bswap(), Philippe Mathieu-Daudé, 2020/09/28
- [PATCH v2 4/8] qemu/bswap: Remove <byteswap.h> dependency, Philippe Mathieu-Daudé, 2020/09/28
- [PATCH v2 3/8] qemu/bswap: Replace bswapXXs() by compiler __builtin_bswap(), Philippe Mathieu-Daudé, 2020/09/28
- [PATCH v2 5/8] qemu/bswap: Use compiler __builtin_bswap() on Haiku, Philippe Mathieu-Daudé, 2020/09/28
- Re: [PATCH v2 5/8] qemu/bswap: Use compiler __builtin_bswap() on Haiku,
Thomas Huth <=
- [PATCH v2 6/8] qemu/bswap: Use compiler __builtin_bswap() on FreeBSD, Philippe Mathieu-Daudé, 2020/09/28
- Re: [PATCH v2 6/8] qemu/bswap: Use compiler __builtin_bswap() on FreeBSD, Ed Maste, 2020/09/28
[PATCH v2 7/8] qemu/bswap: Use compiler __builtin_bswap() on NetBSD, Philippe Mathieu-Daudé, 2020/09/28
[RFC PATCH v2 8/8] tests/vm: Add Haiku test based on their vagrant images, Philippe Mathieu-Daudé, 2020/09/28