[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 7/8] qemu/bswap: Use compiler __builtin_bswap() on NetBSD
From: |
Kamil Rytarowski |
Subject: |
Re: [PATCH v2 7/8] qemu/bswap: Use compiler __builtin_bswap() on NetBSD |
Date: |
Tue, 29 Sep 2020 16:06:10 +0200 |
User-agent: |
Mozilla/5.0 (X11; NetBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 |
On 29.09.2020 10:58, Peter Maydell wrote:
> On Mon, 28 Sep 2020 at 23:02, Kamil Rytarowski <kamil@netbsd.org> wrote:
>>
>> Personally, I prefer using the system headers. but if you want to use
>> the GCC builtins, please go for it.
>
> I'd agree if the system header approach was cross-platform
> or if this was a BSD-only program or if we were aiming for
> complete compiler-implementation independence, but since we
> rely on GCC/clang all over the place already it seems nicer to
> avoid all the machinery for identifying which of the multiple
> different system header implementations is present, and
> instead just have a single implementation that works on
> all the hosts we care about...
>
This is already a part of POSIX:
https://www.austingroupbugs.net/view.php?id=162
We have got everything needed from the standard now to implement bswap
without relying on compiler builtins. Every modern enough POSIX-like OS
already ships with <endian.h>.
> thanks
> -- PMM
>
[RFC PATCH v2 8/8] tests/vm: Add Haiku test based on their vagrant images, Philippe Mathieu-Daudé, 2020/09/28