|
From: | Philippe Mathieu-Daudé |
Subject: | Re: [PATCH 09/24] vt82c686: Convert debug printf to trace points |
Date: | Sun, 3 Jan 2021 13:17:53 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 |
On 1/2/21 11:43 AM, BALATON Zoltan via wrote: > Drop DPRINTF and use trace functions instead. Two debug messages about > unimplemented registers could be converted to qemu_log_mask() but in > reality all registers are currently unimplemented (we just store and > return values of writable regs but do nothing with them). As we > already trace register access there's no need for additional debug > messages so these are just removed and a comment is added as a reminder. > > Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu> > --- > hw/isa/trace-events | 6 ++++++ > hw/isa/vt82c686.c | 51 +++++++++++++-------------------------------- > 2 files changed, 21 insertions(+), 36 deletions(-) Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
[Prev in Thread] | Current Thread | [Next in Thread] |