Re: [PATCH 1/2] vhost-vdpa: fix "unsigned long long" error with stap

[Laurent Vivier]

On 05/01/2021 20:17, Laurent Vivier wrote:
> The "%llu" format type is not understood by stap:
> 
> $ sudo stap -e 'probe begin{printf ("BEGIN")}'  -I .
> 
> parse error: invalid or missing conversion specifier
>           saw: operator ',' at ./qemu-system-x86_64-log.stp:15118:101
>        source:     printf("%d@%d vhost_vdpa_set_log_base dev: %p base: 0x%x 
> size: %llu refcnt: %d fd: %d log: %p\n", pid(), gettimeofday_ns(), dev, base, 
> size, refcnt, fd, log)
>                                                                               
>                                    ^
> 
>   1 parse error.
>   WARNING: tapset "./qemu-system-x86_64-log.stp" has errors, and will be 
> skipped
> 
> commit 35e28cb0f210 ("scripts/tracetool: silence SystemTap dtrace(1)
> long long warnings") has already fixed the problem for the dtrace format
> by dynamically replacing "unsigned long long" by "uint64_t", but as it
> seems the problem can happen with any format and this is the only
> occurrence of this type, simply replace it directly by "uint64_t" in the
> trace-events file.
> 
> Fixes: 778e67de4cd8 ("vhost-vdpa: add trace-events")
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> ---
>  hw/virtio/trace-events | 2 +-
>  hw/virtio/vhost-vdpa.c | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)

Ignore this patch, Daniel has proposed a better fix.

Thanks,
Laurent