[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 6/7] slirp: update build flags for iOS resolv fix
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v6 6/7] slirp: update build flags for iOS resolv fix |
Date: |
Tue, 12 Jan 2021 12:52:28 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 |
Hi Joelle,
On 1/5/21 3:20 AM, Joelle van Dyne wrote:
> A future libslirp update will use libresolv on Darwin systems, so we add the
> flags in QEMU build now.
>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> Signed-off-by: Joelle van Dyne <j@getutm.app>
> ---
> meson.build | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/meson.build b/meson.build
> index 900dbc36c8..d8951d4d6c 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -1205,6 +1205,8 @@ if have_system
> slirp_deps = []
> if targetos == 'windows'
> slirp_deps = cc.find_library('iphlpapi')
> + elif targetos == 'darwin'
> + slirp_deps = cc.find_library('resolv')
This is done in libSLiRP commit 9f82a47 ("Add DNS resolving for iOS").
Maybe this commit need to be backported in the stable branch,
or QEMU should use a newer commit. Cc'ing Samuel and Marc-André
who maintain the project (and the SLiRP list).
> endif
> slirp_conf = configuration_data()
> slirp_conf.set('SLIRP_MAJOR_VERSION',
> meson.project_version().split('.')[0])
>
- [PATCH v6 0/7] iOS and Apple Silicon host support, Joelle van Dyne, 2021/01/04
- [PATCH v6 1/7] configure: option to disable host block devices, Joelle van Dyne, 2021/01/04
- [PATCH v6 2/7] configure: cross-compiling with empty cross_prefix, Joelle van Dyne, 2021/01/04
- [PATCH v6 6/7] slirp: update build flags for iOS resolv fix, Joelle van Dyne, 2021/01/04
- Re: [PATCH v6 6/7] slirp: update build flags for iOS resolv fix,
Philippe Mathieu-Daudé <=
- [PATCH v6 4/7] coroutine: add libucontext as external library, Joelle van Dyne, 2021/01/04
- [PATCH v6 5/7] configure: cross compile should use x86_64 cpu_family, Joelle van Dyne, 2021/01/04
- [PATCH v6 3/7] qemu: add support for iOS host, Joelle van Dyne, 2021/01/04