Re: [PATCH 13/22] tcg: Split out constraint sets to tcg-target-conset.h

[Peter Maydell]

On Wed, 23 Dec 2020 at 06:20, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> This exports the constraint sets from tcg_target_op_def to
> a place we will be able to manipulate more in future.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  tcg/i386/tcg-target-conset.h |  44 ++++++++
>  tcg/i386/tcg-target.h        |   1 +
>  tcg/tcg.c                    | 126 +++++++++++++++++++++++
>  tcg/i386/tcg-target.c.inc    | 189 ++++++++++++-----------------------
>  4 files changed, 236 insertions(+), 124 deletions(-)
>  create mode 100644 tcg/i386/tcg-target-conset.h
>
> diff --git a/tcg/i386/tcg-target-conset.h b/tcg/i386/tcg-target-conset.h
> new file mode 100644
> index 0000000000..5a4f991d78
> --- /dev/null
> +++ b/tcg/i386/tcg-target-conset.h
> @@ -0,0 +1,44 @@
> +/* SPDX-License-Identifier: MIT */
> +/*
> + * i386 target-specific constaint sets.

"constraint"

> + * Copyright (c) 2020 Linaro
> + */
> +
> +C_O0_I1(r)
> +C_O0_I2(L, L)
> +C_O0_I2(qi, r)
> +C_O0_I2(re, r)
> +C_O0_I2(ri, r)
> +C_O0_I2(r, re)
> +C_O0_I2(x, r)

I'm afraid this is completely incomprehensible to me.
Can we have some documentation of what these macros are doing
(which we can then reference in the comment at the top of each
conset.h file)?

thanks
-- PMM